Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introducing new feature in vertical bar chart. added line #15505

Merged
merged 4 commits into from
Oct 22, 2020
Merged

introducing new feature in vertical bar chart. added line #15505

merged 4 commits into from
Oct 22, 2020

Conversation

shivasai09
Copy link
Contributor

@shivasai09 shivasai09 commented Oct 14, 2020 •
edited
Loading

Pull request checklist

Description of changes

added line to the vertical bar chart. according to the figma
https://www.figma.com/file/sRqcZakGJ4VpXFWOwBftSU/Apps-health?node-id=30%3A78

Focus areas to test

vertical bar chart

@shivasai09 shivasai09 requested a review from Raghurk as a code owner October 14, 2020 07:09
@msft-github-bot msft-github-bot added the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Oct 14, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 14, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 08f6321:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-next-template Configuration
codesandbox-react-northstar-template Configuration

@msft-github-bot
Copy link
Contributor

msft-github-bot commented Oct 14, 2020 •
edited
Loading

Perf Analysis

No significant results to display.

All results

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
Avatar mount 926 913 5000
BaseButton mount 1032 1013 5000
Breadcrumb mount 44538 44497 5000
ButtonNext mount 765 731 5000
Checkbox mount 1763 1736 5000
CheckboxBase mount 1427 1468 5000
ChoiceGroup mount 5498 5474 5000
ComboBox mount 1012 999 1000
CommandBar mount 8236 8237 1000
ContextualMenu mount 17403 17112 1000
DefaultButton mount 1295 1274 5000
DetailsRow mount 3973 3949 5000
DetailsRowFast mount 4003 3943 5000
DetailsRowNoStyles mount 3757 3761 5000
Dialog mount 1610 1648 1000
DocumentCardTitle mount 1900 1887 1000
Dropdown mount 2829 2821 5000
FocusTrapZone mount 1781 1811 5000
FocusZone mount 1863 1913 5000
IconButton mount 1958 1963 5000
Label mount 371 366 5000
Layer mount 2138 2103 5000
Link mount 480 494 5000
MenuButton mount 1589 1618 5000
MessageBar mount 2170 2195 5000
Nav mount 3592 3533 1000
OverflowSet mount 1500 1541 5000
Panel mount 1579 1579 1000
Persona mount 874 903 1000
Pivot mount 1561 1580 1000
PrimaryButton mount 1402 1411 5000
Rating mount 8473 8364 5000
SearchBox mount 1379 1429 5000
Shimmer mount 2909 2815 5000
Slider mount 1596 1620 5000
SpinButton mount 5426 5406 5000
Spinner mount 443 447 5000
SplitButton mount 3482 3477 5000
Stack mount 569 544 5000
StackWithIntrinsicChildren mount 1647 1643 5000
StackWithTextChildren mount 5191 5074 5000
SwatchColorPicker mount 11287 11268 5000
TagPicker mount 2994 2951 5000
TeachingBubble mount 53668 53802 5000
Text mount 474 477 5000
TextField mount 1573 1597 5000
ThemeProvider mount 1845 1801 5000
ThemeProvider virtual-rerender 670 655 5000
Toggle mount 885 900 5000
button mount 112 118 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.5 0.52 0.96:1 2000 999
🦄 Button.Fluent 0.14 0.23 0.61:1 5000 684
🔧 Checkbox.Fluent 0.69 0.4 1.73:1 1000 691
🎯 Dialog.Fluent 0.18 0.24 0.75:1 5000 920
🔧 Dropdown.Fluent 3.23 0.52 6.21:1 1000 3225
🔧 Icon.Fluent 0.17 0.07 2.43:1 5000 830
🦄 Image.Fluent 0.09 0.13 0.69:1 5000 467
🔧 Slider.Fluent 1.72 0.41 4.2:1 1000 1720
🔧 Text.Fluent 0.09 0.04 2.25:1 5000 448
🦄 Tooltip.Fluent 0.13 19.35 0.01:1 5000 632

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AccordionMinimalPerf.default 191 0 Infinity:1
AlertMinimalPerf.default 358 0 Infinity:1
AnimationMinimalPerf.default 481 0 Infinity:1
AttachmentMinimalPerf.default 222 0 Infinity:1
AttachmentSlotsPerf.default 1268 0 Infinity:1
AvatarMinimalPerf.default 557 0 Infinity:1
ButtonOverridesMissPerf.default 1870 0 Infinity:1
ButtonSlotsPerf.default 698 0 Infinity:1
ButtonUseCssPerf.default 968 0 Infinity:1
CardMinimalPerf.default 655 0 Infinity:1
CarouselMinimalPerf.default 526 0 Infinity:1
ChatDuplicateMessagesPerf.default 466 0 Infinity:1
ChatWithPopoverPerf.default 535 0 Infinity:1
CheckboxMinimalPerf.default 3126 0 Infinity:1
DialogMinimalPerf.default 907 0 Infinity:1
DividerMinimalPerf.default 453 0 Infinity:1
DropdownManyItemsPerf.default 867 0 Infinity:1
DropdownMinimalPerf.default 3179 0 Infinity:1
FlexMinimalPerf.default 363 0 Infinity:1
FormMinimalPerf.default 494 0 Infinity:1
GridMinimalPerf.default 436 0 Infinity:1
HeaderMinimalPerf.default 447 0 Infinity:1
ImageMinimalPerf.default 481 0 Infinity:1
ItemLayoutMinimalPerf.default 1484 0 Infinity:1
LabelMinimalPerf.default 499 0 Infinity:1
LayoutMinimalPerf.default 495 0 Infinity:1
ListCommonPerf.default 766 0 Infinity:1
ListMinimalPerf.default 584 0 Infinity:1
ListNestedPerf.default 677 0 Infinity:1
ListWith60ListItems.default 1030 0 Infinity:1
MenuMinimalPerf.default 972 0 Infinity:1
MenuButtonMinimalPerf.default 1784 0 Infinity:1
PopupMinimalPerf.default 784 0 Infinity:1
PortalMinimalPerf.default 179 0 Infinity:1
ProviderMergeThemesPerf.default 2209 0 Infinity:1
ProviderMinimalPerf.default 1116 0 Infinity:1
ReactionMinimalPerf.default 482 0 Infinity:1
RefMinimalPerf.default 254 0 Infinity:1
SegmentMinimalPerf.default 410 0 Infinity:1
SkeletonMinimalPerf.default 514 0 Infinity:1
SliderMinimalPerf.default 1692 0 Infinity:1
SplitButtonMinimalPerf.default 4301 0 Infinity:1
StatusMinimalPerf.default 843 0 Infinity:1
IconMinimalPerf.default 813 0 Infinity:1
TableMinimalPerf.default 497 0 Infinity:1
TextMinimalPerf.default 455 0 Infinity:1
TextAreaMinimalPerf.default 594 0 Infinity:1
CustomToolbarPrototype.default 4281 0 Infinity:1
ToolbarMinimalPerf.default 1090 0 Infinity:1
TooltipMinimalPerf.default 915 0 Infinity:1
TreeMinimalPerf.default 1032 0 Infinity:1
TreeWith60ListItems.default 240 0 Infinity:1
VideoMinimalPerf.default 793 0 Infinity:1
Avatar.Fluent 999 0 Infinity:1
Button.Fluent 684 0 Infinity:1
Checkbox.Fluent 691 0 Infinity:1
Dialog.Fluent 920 0 Infinity:1
Dropdown.Fluent 3225 0 Infinity:1
Icon.Fluent 830 0 Infinity:1
Image.Fluent 467 0 Infinity:1
Slider.Fluent 1720 0 Infinity:1
Tooltip.Fluent 632 0 Infinity:1
TableManyItemsPerf.default 2543 1 2543:1
EmbedMinimalPerf.default 2206 1 2206:1
InputMinimalPerf.default 1430 1 1430:1
ButtonUseCssNestingPerf.default 1234 1 1234:1
HeaderSlotsPerf.default 929 1 929:1
LoaderMinimalPerf.default 811 1 811:1
ChatMinimalPerf.default 726 1 726:1
RadioGroupMinimalPerf.default 524 1 524:1
Text.Fluent 448 1 448:1
BoxMinimalPerf.default 437 1 437:1
ButtonMinimalPerf.default 214 1 214:1

@size-auditor
Copy link

size-auditor bot commented Oct 14, 2020 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 8828fdca589a3b4f9119798fb806163e29961a41 (build)

@khmakoto khmakoto mentioned this pull request Oct 15, 2020
Closed
40 tasks
@Raghurk Raghurk merged commit 0239b7d into microsoft:7.0 Oct 22, 2020
@msft-github-bot
Copy link
Contributor

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@uifabric/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot msft-github-bot mentioned this pull request Oct 22, 2020
Closed
@khmakoto khmakoto mentioned this pull request Oct 26, 2020
Merged
2 tasks
ecraig12345 pushed a commit that referenced this pull request Oct 27, 2020
@khmakoto
Charting: Added line feature to VerticalBarChart (#15705)
4858df7 
Cherry-pick of #15505.
SethDonohue pushed a commit to SethDonohue/fluentui that referenced this pull request Nov 2, 2020
@khmakoto
Charting: Added line feature to VerticalBarChart (microsoft#15705)
72762db 
Cherry-pick of microsoft#15505.
@ecraig12345 ecraig12345 removed the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raghurk Raghurk Raghurk approved these changes

Assignees

@tomi-msft tomi-msft

Labels
Package: charting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shivasai09 @msft-github-bot @Raghurk @ecraig12345 @tomi-msft