-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom KeyUp support to Group Header #15478
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 861894f:
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 33a6732:
|
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Asset size changes
Over Tolerance (1024 B) Over Baseline Below Baseline New Removed 1 kB = 1000 B Baseline commit: 172f3340317a7f3d434d82334716db24b3b63ede (build) |
Is there something that I should be doing about this? |
packages/office-ui-fabric-react/etc/office-ui-fabric-react.api.md
Outdated
Show resolved
Hide resolved
packages/office-ui-fabric-react/src/components/GroupedList/GroupHeader.base.tsx
Outdated
Show resolved
Hide resolved
packages/office-ui-fabric-react/src/components/GroupedList/GroupHeader.base.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
packages/office-ui-fabric-react/src/components/GroupedList/GroupedList.types.ts
Outdated
Show resolved
Hide resolved
Hello @khmakoto! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
🎉 Handy links: |
…15624) <!-- !!!!!!! IMPORTANT !!!!!!! Due to work we're currently doing to prepare master branch for our version 8 beta release, please hold-off submitting the PR until around October 12 if it's not urgent. If it is urgent, please submit the PR targeting the 7.0 branch. This change does not apply to react-northstar contributors. See #15222 for more details. Sorry for the inconvenience and short notice. --> #### Pull request checklist - [ ] Addresses an existing issue: Fixes #0000 - [x] Include a change request file using `$ yarn change` #### Description of changes _Cherry-pick of #15478._ _Original PR description:_ Give the user the ability to override what happens with KeyUp. Currently it is only used with Right/Left to expand and collapse the group. #### Focus areas to test Ensure that Right/Left to expand and collapse still works.
…icrosoft#15624) <!-- !!!!!!! IMPORTANT !!!!!!! Due to work we're currently doing to prepare master branch for our version 8 beta release, please hold-off submitting the PR until around October 12 if it's not urgent. If it is urgent, please submit the PR targeting the 7.0 branch. This change does not apply to react-northstar contributors. See microsoft#15222 for more details. Sorry for the inconvenience and short notice. --> #### Pull request checklist - [ ] Addresses an existing issue: Fixes #0000 - [x] Include a change request file using `$ yarn change` #### Description of changes _Cherry-pick of microsoft#15478._ _Original PR description:_ Give the user the ability to override what happens with KeyUp. Currently it is only used with Right/Left to expand and collapse the group. #### Focus areas to test Ensure that Right/Left to expand and collapse still works.
Pull request checklist
$ yarn change
Description of changes
Give the user the ability to override what happens with KeyUp. Currently it is only used with Right/Left to expand and collapse the group.
Focus areas to test
Ensure that Right/Left to expand and collapse still works.