fix for positioning logic land on fractional values #15469
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractional values in this place cause hard to debug subpixel rendering problems
msft-github-bot
added
Component: ContextualMenu
needs cherry-pick
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f97bf11:
|
Perf AnalysisNo significant results to display. All results
|
Asset size changes
Baseline commit: 25a4e0e7783de5d8f733ca85a762c2308823438e (build) |
40 tasks
paulgildea
added
the
Contribution Candidate
|
Now that we're publishing beta versions of 8.0 please also port this to the master branch once it merges. |
joschect
approved these changes
Dec 17, 2020
|
@dev-a11y can you please generate a changelog entry via |
|
@layershifter, sorry - had some difficulties setting up env on my machine, latest build error was sth with electron package installation and I gave it a rest; please reject this pull request and if still valid that code adjustment can be pushed by someone else; I'll remove my branch/fork soon |
ecraig12345
removed
the
needs cherry-pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fractional values in this place cause hard to debug subpixel rendering problems
Pull request checklist
$ yarn changeDescription of changes
see discussion in related issue