-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
charting: Grouped vertical bar chart code refactor. #15468
charting: Grouped vertical bar chart code refactor. #15468
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 85928b9:
|
Perf AnalysisNo significant results to display. All results
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: e631d61d95d145043bfa3f08ae0b4a1ae0bf8d5a (build) |
Now that we're publishing beta versions of 8.0 please also port this to the master branch once it merges. |
🎉 Handy links: |
🎉 Handy links: |
cc @ecraig12345: Ported to |
Pull request checklist
$ yarn change
Description of changes
In the process of restructure of the Groped vertical bar chart,
Removed d3 related graph structure and updated with rectangles.
Implemented with Cartesian chart(Common component)
YMinValue and YMaxValue support added
Added support of yAxisTickFormat.
Customized callout support implemented.
Code cleanup
Snapshot and basic level unit test cases added
Deprecated below props(Made them as default props).
Note: As RTL support and word wrap of x axis already implemented for this chart, Now it's working as like previous. Attacked screenshots.
Focus areas to test
Grouped vertical bar chart
Grouped vertical bar chart with custom callout
yMax value support - with 100000 as Max value
RTL Support
Test link: http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/15468/merge/charting/dist/index.html#/examples/GroupedVerticalBarChart