Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor edits to the area chart #15403

Merged
merged 4 commits into from
Oct 9, 2020
Merged

minor edits to the area chart #15403

merged 4 commits into from
Oct 9, 2020

Conversation

shivasai09
Copy link
Contributor

Pull request checklist

Description of changes

minor edits to area chart according to the figma https://www.figma.com/file/BJaI0aMC0jXuwsJaGofqM7/Visualizations-(PS-%2B-CFR)?node-id=1093%3A12

Focus areas to test

area chart

@shivasai09 shivasai09 requested a review from Raghurk as a code owner October 7, 2020 10:50
@msft-github-bot msft-github-bot added the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Oct 7, 2020
@shivasai09 shivasai09 changed the title User/v sivsar/areachart edits minor edits to the area chart Oct 7, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 7, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7d47484:

Sandbox Source
Fluent UI Button Configuration
microsoft/fluentui: codesandbox-react-template Configuration
microsoft/fluentui: codesandbox-react-next-template Configuration
microsoft/fluentui: codesandbox-react-northstar-template Configuration

@msft-github-bot
Copy link
Contributor

msft-github-bot commented Oct 7, 2020 •
edited
Loading

Perf Analysis

No significant results to display.

All results

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
Avatar mount 842 830 5000
BaseButton mount 905 934 5000
Breadcrumb mount 39630 39795 5000
ButtonNext mount 554 552 5000
Checkbox mount 1582 1562 5000
CheckboxBase mount 1352 1294 5000
ChoiceGroup mount 5031 4990 5000
ComboBox mount 925 909 1000
CommandBar mount 7414 7423 1000
ContextualMenu mount 12372 12445 1000
DefaultButton mount 1133 1142 5000
DetailsRow mount 3667 3697 5000
DetailsRowFast mount 3618 3662 5000
DetailsRowNoStyles mount 3393 3501 5000
Dialog mount 1514 1466 1000
DocumentCardTitle mount 1763 1742 1000
Dropdown mount 2597 2577 5000
FocusTrapZone mount 1665 1712 5000
FocusZone mount 1739 1735 5000
IconButton mount 1805 1804 5000
Label mount 327 337 5000
Layer mount 1961 1973 5000
Link mount 423 440 5000
MenuButton mount 1534 1470 5000
MessageBar mount 2004 2030 5000
Nav mount 3304 3307 1000
OverflowSet mount 1409 1365 5000
Panel mount 1415 1436 1000
Persona mount 826 817 1000
Pivot mount 1432 1426 1000
PrimaryButton mount 1289 1270 5000
Rating mount 7868 7742 5000
SearchBox mount 1289 1299 5000
Shimmer mount 2605 2596 5000
Slider mount 1507 1526 5000
SpinButton mount 5063 5028 5000
Spinner mount 405 418 5000
SplitButton mount 3219 3198 5000
Stack mount 509 515 5000
StackWithIntrinsicChildren mount 1981 2018 5000
StackWithTextChildren mount 5156 5202 5000
SwatchColorPicker mount 10439 10453 5000
TagPicker mount 2780 2747 5000
TeachingBubble mount 48625 48547 5000
Text mount 436 442 5000
TextField mount 1476 1458 5000
ThemeProvider mount 1622 1647 5000
ThemeProvider virtual-rerender 621 644 5000
Toggle mount 805 850 5000
button mount 109 117 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.47 0.49 0.96:1 2000 933
🦄 Button.Fluent 0.13 0.2 0.65:1 5000 636
🔧 Checkbox.Fluent 0.66 0.37 1.78:1 1000 657
🎯 Dialog.Fluent 0.16 0.23 0.7:1 5000 811
🔧 Dropdown.Fluent 2.92 0.5 5.84:1 1000 2924
🔧 Icon.Fluent 0.15 0.07 2.14:1 5000 765
🎯 Image.Fluent 0.09 0.12 0.75:1 5000 448
🔧 Slider.Fluent 1.61 0.37 4.35:1 1000 1610
🔧 Text.Fluent 0.08 0.03 2.67:1 5000 394
🦄 Tooltip.Fluent 0.12 14.71 0.01:1 5000 586

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AccordionMinimalPerf.default 161 0 Infinity:1
AlertMinimalPerf.default 318 0 Infinity:1
AnimationMinimalPerf.default 440 0 Infinity:1
AttachmentMinimalPerf.default 168 0 Infinity:1
ButtonOverridesMissPerf.default 1750 0 Infinity:1
ButtonUseCssPerf.default 878 0 Infinity:1
ButtonUseCssNestingPerf.default 1118 0 Infinity:1
CardMinimalPerf.default 625 0 Infinity:1
CarouselMinimalPerf.default 482 0 Infinity:1
ChatDuplicateMessagesPerf.default 437 0 Infinity:1
ChatMinimalPerf.default 660 0 Infinity:1
ChatWithPopoverPerf.default 478 0 Infinity:1
CheckboxMinimalPerf.default 2895 0 Infinity:1
DialogMinimalPerf.default 833 0 Infinity:1
DividerMinimalPerf.default 424 0 Infinity:1
DropdownManyItemsPerf.default 812 0 Infinity:1
DropdownMinimalPerf.default 2932 0 Infinity:1
EmbedMinimalPerf.default 2046 0 Infinity:1
FlexMinimalPerf.default 349 0 Infinity:1
HeaderMinimalPerf.default 427 0 Infinity:1
HeaderSlotsPerf.default 863 0 Infinity:1
ImageMinimalPerf.default 451 0 Infinity:1
InputMinimalPerf.default 1323 0 Infinity:1
ItemLayoutMinimalPerf.default 1347 0 Infinity:1
LabelMinimalPerf.default 455 0 Infinity:1
LayoutMinimalPerf.default 446 0 Infinity:1
ListMinimalPerf.default 536 0 Infinity:1
ListNestedPerf.default 615 0 Infinity:1
ListWith60ListItems.default 964 0 Infinity:1
LoaderMinimalPerf.default 764 0 Infinity:1
MenuMinimalPerf.default 909 0 Infinity:1
PopupMinimalPerf.default 724 0 Infinity:1
ProviderMinimalPerf.default 1041 0 Infinity:1
RefMinimalPerf.default 234 0 Infinity:1
SegmentMinimalPerf.default 399 0 Infinity:1
SkeletonMinimalPerf.default 476 0 Infinity:1
SliderMinimalPerf.default 1618 0 Infinity:1
SplitButtonMinimalPerf.default 3992 0 Infinity:1
StatusMinimalPerf.default 798 0 Infinity:1
IconMinimalPerf.default 740 0 Infinity:1
TableMinimalPerf.default 466 0 Infinity:1
TextMinimalPerf.default 406 0 Infinity:1
CustomToolbarPrototype.default 3989 0 Infinity:1
ToolbarMinimalPerf.default 1026 0 Infinity:1
TooltipMinimalPerf.default 876 0 Infinity:1
TreeMinimalPerf.default 954 0 Infinity:1
TreeWith60ListItems.default 210 0 Infinity:1
VideoMinimalPerf.default 675 0 Infinity:1
Button.Fluent 636 0 Infinity:1
Checkbox.Fluent 657 0 Infinity:1
Dialog.Fluent 811 0 Infinity:1
Dropdown.Fluent 2924 0 Infinity:1
Icon.Fluent 765 0 Infinity:1
Image.Fluent 448 0 Infinity:1
Text.Fluent 394 0 Infinity:1
Tooltip.Fluent 586 0 Infinity:1
TableManyItemsPerf.default 2396 1 2396:1
ProviderMergeThemesPerf.default 1986 1 1986:1
MenuButtonMinimalPerf.default 1675 1 1675:1
Slider.Fluent 1610 1 1610:1
AttachmentSlotsPerf.default 1194 1 1194:1
Avatar.Fluent 933 1 933:1
ListCommonPerf.default 660 1 660:1
ButtonSlotsPerf.default 633 1 633:1
TextAreaMinimalPerf.default 545 1 545:1
AvatarMinimalPerf.default 502 1 502:1
RadioGroupMinimalPerf.default 492 1 492:1
FormMinimalPerf.default 480 1 480:1
ReactionMinimalPerf.default 441 1 441:1
BoxMinimalPerf.default 429 1 429:1
GridMinimalPerf.default 395 1 395:1
ButtonMinimalPerf.default 207 1 207:1
PortalMinimalPerf.default 162 1 162:1

@size-auditor
Copy link

size-auditor bot commented Oct 7, 2020 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 7bac606fa371d6ca46fe69611da12a3cb0af6a4e (build)

@khmakoto khmakoto mentioned this pull request Oct 7, 2020
Closed
40 tasks
@Raghurk Raghurk merged commit fba5c1c into microsoft:7.0 Oct 9, 2020
@msft-github-bot
Copy link
Contributor

🎉@uifabric/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@khmakoto khmakoto mentioned this pull request Oct 24, 2020
Merged
2 tasks
ecraig12345 pushed a commit that referenced this pull request Oct 24, 2020
@khmakoto
Charting: Changing hover behavior of circles and removing focus of ci…
fd68400 
…rcles (#15686)

Cherry-pick of #15403.
SethDonohue pushed a commit to SethDonohue/fluentui that referenced this pull request Nov 2, 2020
@khmakoto
Charting: Changing hover behavior of circles and removing focus of ci…
6362a0f 
…rcles (microsoft#15686)

Cherry-pick of microsoft#15403.
@ecraig12345 ecraig12345 removed the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raghurk Raghurk Raghurk approved these changes

Assignees

@tomi-msft tomi-msft

Labels
Package: charting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shivasai09 @msft-github-bot @Raghurk @ecraig12345 @tomi-msft