Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lint rule for import paths #15339

Merged
merged 3 commits into from
Oct 2, 2020
Merged

Fix lint rule for import paths #15339

merged 3 commits into from
Oct 2, 2020

Conversation

xugao
Copy link
Contributor

@xugao xugao commented Oct 2, 2020 •
edited
Loading

Pull request checklist

Description of changes

  • Fix import path in lint-imports.js.
  • Fix lint errors.

master branch fix: #15340

Focus areas to test

(optional)

@msft-github-bot msft-github-bot added Area: Build System needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master labels Oct 2, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 2, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5b33cff:

Sandbox Source
Fluent UI Button Configuration
microsoft/fluentui: codesandbox-react-template Configuration
microsoft/fluentui: codesandbox-react-next-template Configuration
microsoft/fluentui: codesandbox-react-northstar-template Configuration

@xugao xugao mentioned this pull request Oct 2, 2020
Merged
2 tasks
@xugao xugao removed the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Oct 2, 2020
ecraig12345
ecraig12345 approved these changes Oct 2, 2020
View reviewed changes
Copy link
Member

@ecraig12345 ecraig12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I'd wondered how those were sneaking through...

@ecraig12345 ecraig12345 merged commit 17b03b1 into microsoft:7.0 Oct 2, 2020
@msft-github-bot
Copy link
Contributor

🎉@uifabric/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@uifabric/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@uifabric/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@uifabric/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot msft-github-bot mentioned this pull request Oct 2, 2020
Closed
@khmakoto khmakoto mentioned this pull request Oct 9, 2020
Closed
40 tasks
@msft-github-bot
Copy link
Contributor

🎉This issue was addressed in #15340, which has now been successfully released as @fluentui/[email protected].:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉This issue was addressed in #15340, which has now been successfully released as @fluentui/[email protected].:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉This issue was addressed in #15340, which has now been successfully released as @fluentui/[email protected].:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecraig12345 ecraig12345 ecraig12345 approved these changes

@dzearing dzearing Awaiting requested review from dzearing dzearing is a code owner

@evlevy evlevy Awaiting requested review from evlevy evlevy is a code owner

@jurokapsiar jurokapsiar Awaiting requested review from jurokapsiar

@khmakoto khmakoto Awaiting requested review from khmakoto

@kolaps33 kolaps33 Awaiting requested review from kolaps33

@lorejoh12 lorejoh12 Awaiting requested review from lorejoh12

@pompomon pompomon Awaiting requested review from pompomon

@Raghurk Raghurk Awaiting requested review from Raghurk

Assignees

@miroslavstastny miroslavstastny

Labels
Area: Build System
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xugao @msft-github-bot @ecraig12345 @miroslavstastny