Fix propagation of items and groups props from DetailsList through GroupedList #15321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this change, but due to work currently in progress to prepare |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 88190ce:
|
Asset size changesUnable to find bundle size details for Baseline commit: f4b052d Possible causes
Recommendations
|
dzearing
requested review from
assuncaocharles,
ecraig12345,
JasonGore,
jurokapsiar,
khmakoto,
kolaps33,
layershifter,
miroslavstastny,
pompomon and
xugao
as code owners
ThomasMichon
force-pushed
the
group-state
branch
from
92762d9 to
88190ce
Compare
ThomasMichon
requested review from
behowell,
bigbadcapers,
evlevy,
hyoshis,
Jacqueline-ms,
Jahnp,
joschect,
lorejoh12,
Raghurk and
wsmd
as code owners
dzearing
approved these changes
Sep 30, 2020
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
ecraig12345
added
the
needs cherry-pick
ecraig12345
approved these changes
Sep 30, 2020
|
Hello @ThomasMichon! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 3 hours 20 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
40 tasks
khmakoto
approved these changes
Oct 1, 2020
|
🎉 Handy links: |
2 tasks
msft-github-bot
pushed a commit
that referenced
this pull request
Oct 20, 2020
…oupedList (#15605) <!-- !!!!!!! IMPORTANT !!!!!!! Due to work we're currently doing to prepare master branch for our version 8 beta release, please hold-off submitting the PR until around October 12 if it's not urgent. If it is urgent, please submit the PR targeting the 7.0 branch. This change does not apply to react-northstar contributors. See #15222 for more details. Sorry for the inconvenience and short notice. --> #### Pull request checklist - [ ] Addresses an existing issue: Fixes #0000 - [x] Include a change request file using `$ yarn change` #### Description of changes _Cherry-pick of #15321._ _Original PR description:_ Fixed an issue in the recent rework to use `getDerivedStateFromProps` in the `GroupedList` component: the new function was inadvertently checking new input props values *against themselves* rather than the previous state. This issue is now fixed, and the `DetailsList` input state now propagates correctly through `GroupedList`. Added some unit tests for `DetailsList` explicitly in order to validate that re-rendering a `DetailsList` with new inputs for `items` or `groups` properly updates for each type of transition. #### Focus areas to test Validate `DetailsList` when changing the `items` or `groups` props. Added a unit test explicitly for this.
SethDonohue
pushed a commit
to SethDonohue/fluentui
that referenced
this pull request
Nov 2, 2020
…oupedList (microsoft#15605) <!-- !!!!!!! IMPORTANT !!!!!!! Due to work we're currently doing to prepare master branch for our version 8 beta release, please hold-off submitting the PR until around October 12 if it's not urgent. If it is urgent, please submit the PR targeting the 7.0 branch. This change does not apply to react-northstar contributors. See microsoft#15222 for more details. Sorry for the inconvenience and short notice. --> #### Pull request checklist - [ ] Addresses an existing issue: Fixes #0000 - [x] Include a change request file using `$ yarn change` #### Description of changes _Cherry-pick of microsoft#15321._ _Original PR description:_ Fixed an issue in the recent rework to use `getDerivedStateFromProps` in the `GroupedList` component: the new function was inadvertently checking new input props values *against themselves* rather than the previous state. This issue is now fixed, and the `DetailsList` input state now propagates correctly through `GroupedList`. Added some unit tests for `DetailsList` explicitly in order to validate that re-rendering a `DetailsList` with new inputs for `items` or `groups` properly updates for each type of transition. #### Focus areas to test Validate `DetailsList` when changing the `items` or `groups` props. Added a unit test explicitly for this.
ecraig12345
removed
the
needs cherry-pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixed an issue in the recent rework to use
getDerivedStateFromPropsin theGroupedListcomponent: the new function was inadvertently checking new input props values against themselves rather than the previous state. This issue is now fixed, and theDetailsListinput state now propagates correctly throughGroupedList.Added some unit tests for
DetailsListexplicitly in order to validate that re-rendering aDetailsListwith new inputs foritemsorgroupsproperly updates for each type of transition.Focus areas to test
Validate
DetailsListwhen changing theitemsorgroupsprops. Added a unit test explicitly for this.