Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: design system property inheritance #15106

Merged
merged 3 commits into from
Sep 17, 2020
Merged

Fix: design system property inheritance #15106

merged 3 commits into from
Sep 17, 2020

Conversation

eljefe223
Copy link
Contributor

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

This fixes an issue where other design system properties like direction were not being passed down to the extended DSP.

chrisdholt
chrisdholt approved these changes Sep 17, 2020
View reviewed changes
Copy link
Member

@chrisdholt chrisdholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on that one change coming in

@chrisdholt chrisdholt merged commit 82d4558 into microsoft:master Sep 17, 2020
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 14f6994:

Sandbox Source
Fluent UI Button Configuration
microsoft/fluentui: codesandbox-react-template Configuration
microsoft/fluentui: codesandbox-react-next-template Configuration
microsoft/fluentui: codesandbox-react-northstar-template Configuration

@size-auditor
Copy link

size-auditor bot commented Sep 17, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 499321957f7e9c10baa3b769b5e1284fde48294d (build)

@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 899 900 5000
Breadcrumb mount 39807 40016 5000
BreadcrumbNext mount 154668 153261 5000
ButtonNext mount 616 621 5000
Checkbox mount 1576 1610 5000
CheckboxBase mount 1359 1374 5000
CheckboxNext mount 1543 1562 5000
ChoiceGroup mount 5033 5048 5000
ChoiceGroupNext mount 5069 5024 5000
ComboBox mount 908 957 1000
CommandBar mount 7361 7387 1000
ContextualMenu mount 12334 12136 1000
DefaultButton mount 1152 1114 5000
DetailsRow mount 3651 3627 5000
DetailsRowFast mount 3616 3605 5000
DetailsRowNoStyles mount 3402 3445 5000
Dialog mount 1492 1531 1000
DocumentCardTitle mount 1757 1771 1000
Dropdown mount 2630 2600 5000
FocusZone mount 1753 1762 5000
IconButton mount 1802 1787 5000
Label mount 341 345 5000
Link mount 467 456 5000
LinkNext mount 480 474 5000
MenuButton mount 1484 1540 5000
MessageBar mount 2027 2027 5000
MessageBarNext mount 1985 2027 5000
Nav mount 3231 3299 1000
OverflowSet mount 1414 1420 5000
OverflowSetNext mount 1037 1033 5000
Panel mount 1509 1432 1000
Persona mount 849 841 1000
Pivot mount 1439 1459 1000
PivotNext mount 1412 1403 1000
PrimaryButton mount 1282 1316 5000
Rating mount 7942 8025 5000
RatingNext mount 7737 7763 5000
SearchBox mount 1341 1320 5000
SearchBoxNext mount 1347 1346 5000
Shimmer mount 2683 2768 5000
ShimmerNext mount 2580 2702 5000
Slider mount 1553 1580 5000
SliderNext mount 1987 1934 5000
SpinButton mount 4986 5039 5000
SpinButtonNext mount 5147 5104 5000
Spinner mount 414 422 5000
SplitButton mount 3149 3534 5000
Stack mount 534 532 5000
StackWithIntrinsicChildren mount 2000 2056 5000
StackWithTextChildren mount 5231 5223 5000
SwatchColorPicker mount 10239 10165 5000
SwatchColorPickerNext mount 10157 10403 5000
TagPicker mount 2804 2828 5000
TeachingBubble mount 48613 48166 5000
TeachingBubbleNext mount 48238 48205 5000
Text mount 424 442 5000
TextField mount 1391 1427 5000
ThemeProvider mount 4847 4865 5000
ThemeProvider virtual-rerender 592 599 5000
Toggle mount 864 838 5000
ToggleNext mount 829 831 5000
button mount 118 118 5000

Perf Analysis (Fluent)

⚠️ 5 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
ButtonOverridesMissPerf.default 1728 42 41.14:1 analysis
ButtonUseCssNestingPerf.default 1113 47 23.68:1 analysis
ButtonUseCssPerf.default 872 48 18.17:1 analysis
ChatWithPopoverPerf.default 490 482 1.02:1 analysis
ListNestedPerf.default 625 906 0.69:1 analysis
Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.47 0.5 0.94:1 2000 936
🦄 Button.Fluent 0.13 0.2 0.65:1 5000 643
🔧 Checkbox.Fluent 0.64 0.36 1.78:1 1000 639
🎯 Dialog.Fluent 0.17 0.22 0.77:1 5000 832
🔧 Dropdown.Fluent 2.94 0.48 6.13:1 1000 2943
🔧 Icon.Fluent 0.15 0.06 2.5:1 5000 762
🎯 Image.Fluent 0.09 0.12 0.75:1 5000 440
🔧 Slider.Fluent 1.59 0.36 4.42:1 1000 1594
🔧 Text.Fluent 0.08 0.03 2.67:1 5000 405
🦄 Tooltip.Fluent 0.11 14.85 0.01:1 5000 571

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
PortalMinimalPerf.default 167 122 1.37:1
FlexMinimalPerf.default 329 261 1.26:1
RefMinimalPerf.default 247 197 1.25:1
Text.Fluent 405 325 1.25:1
IconMinimalPerf.default 758 627 1.21:1
BoxMinimalPerf.default 406 337 1.2:1
GridMinimalPerf.default 398 333 1.2:1
TextMinimalPerf.default 402 338 1.19:1
LabelMinimalPerf.default 478 405 1.18:1
HeaderMinimalPerf.default 425 363 1.17:1
ReactionMinimalPerf.default 446 384 1.16:1
Button.Fluent 643 554 1.16:1
Image.Fluent 440 378 1.16:1
DividerMinimalPerf.default 405 353 1.15:1
FormMinimalPerf.default 470 407 1.15:1
SkeletonMinimalPerf.default 465 407 1.14:1
TableMinimalPerf.default 452 398 1.14:1
AnimationMinimalPerf.default 430 379 1.13:1
ChatMinimalPerf.default 693 612 1.13:1
ImageMinimalPerf.default 435 385 1.13:1
StatusMinimalPerf.default 769 686 1.12:1
ToolbarMinimalPerf.default 1027 914 1.12:1
Tooltip.Fluent 571 510 1.12:1
ButtonMinimalPerf.default 187 169 1.11:1
SegmentMinimalPerf.default 381 342 1.11:1
TooltipMinimalPerf.default 844 762 1.11:1
AttachmentMinimalPerf.default 172 157 1.1:1
HeaderSlotsPerf.default 847 772 1.1:1
AccordionMinimalPerf.default 167 153 1.09:1
CardMinimalPerf.default 618 567 1.09:1
LayoutMinimalPerf.default 446 408 1.09:1
ProviderMinimalPerf.default 986 904 1.09:1
RadioGroupMinimalPerf.default 455 416 1.09:1
TextAreaMinimalPerf.default 566 517 1.09:1
Icon.Fluent 762 696 1.09:1
AvatarMinimalPerf.default 503 466 1.08:1
ChatDuplicateMessagesPerf.default 457 423 1.08:1
DialogMinimalPerf.default 826 768 1.08:1
PopupMinimalPerf.default 738 684 1.08:1
TreeMinimalPerf.default 945 879 1.08:1
ListMinimalPerf.default 524 488 1.07:1
MenuMinimalPerf.default 911 851 1.07:1
Dialog.Fluent 832 777 1.07:1
DropdownManyItemsPerf.default 803 761 1.06:1
EmbedMinimalPerf.default 2017 1917 1.05:1
MenuButtonMinimalPerf.default 1652 1571 1.05:1
ProviderMergeThemesPerf.default 1922 1828 1.05:1
ButtonSlotsPerf.default 631 608 1.04:1
CarouselMinimalPerf.default 480 461 1.04:1
ItemLayoutMinimalPerf.default 1346 1297 1.04:1
CustomToolbarPrototype.default 3782 3652 1.04:1
Checkbox.Fluent 639 612 1.04:1
AlertMinimalPerf.default 330 319 1.03:1
AttachmentSlotsPerf.default 1202 1162 1.03:1
CheckboxMinimalPerf.default 2919 2823 1.03:1
DropdownMinimalPerf.default 2930 2854 1.03:1
InputMinimalPerf.default 1325 1286 1.03:1
VideoMinimalPerf.default 683 665 1.03:1
LoaderMinimalPerf.default 751 735 1.02:1
Dropdown.Fluent 2943 2876 1.02:1
SliderMinimalPerf.default 1601 1578 1.01:1
SplitButtonMinimalPerf.default 3862 3807 1.01:1
TableManyItemsPerf.default 2352 2318 1.01:1
Avatar.Fluent 936 924 1.01:1
Slider.Fluent 1594 1606 0.99:1
TreeWith60ListItems.default 218 224 0.97:1
ListWith60ListItems.default 975 1101 0.89:1
ListCommonPerf.default 713 964 0.74:1

@msft-github-bot
Copy link
Contributor

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdholt chrisdholt chrisdholt approved these changes

Assignees
No one assigned
Labels
web-components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eljefe223 @msft-github-bot @chrisdholt