Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving Breadcrumb to react-next, in preparation for converting to a function component #15054

Merged
merged 7 commits into from
Sep 16, 2020
Merged

Moving Breadcrumb to react-next, in preparation for converting to a function component #15054

merged 7 commits into from
Sep 16, 2020

Conversation

czearing
Copy link
Collaborator

Pull request checklist

  • Include a change request file using $ yarn change

Description of changes

This change does not modify Breadcrumb ; it simply moves it to react-next for better diffing in the actual conversion PR.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 15, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a2e13cf:

Sandbox Source
Fluent UI Button Configuration
microsoft/fluentui: codesandbox-react-template Configuration
microsoft/fluentui: codesandbox-react-next-template Configuration
microsoft/fluentui: codesandbox-react-northstar-template Configuration

@msft-github-bot
Copy link
Contributor

msft-github-bot commented Sep 15, 2020 •
edited
Loading

Perf Analysis

Scenario Render type Master Ticks PR Ticks Iterations Status
Breadcrumb mount 50 39793 5000 Possible regression
BreadcrumbNext mount 49 152291 5000 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 820 840 5000
Breadcrumb mount 50 39793 5000 Possible regression
BreadcrumbNext mount 49 152291 5000 Possible regression
ButtonNext mount 540 545 5000
Checkbox mount 1501 1474 5000
CheckboxBase mount 1198 1232 5000
CheckboxNext mount 1397 1413 5000
ChoiceGroup mount 4694 4646 5000
ChoiceGroupNext mount 4635 4694 5000
ComboBox mount 925 856 1000
CommandBar mount 7148 7207 1000
ContextualMenu mount 12688 12690 1000
DefaultButton mount 1067 1067 5000
DetailsRow mount 3314 3294 5000
DetailsRowFast mount 3342 3323 5000
DetailsRowNoStyles mount 3178 3113 5000
Dialog mount 1446 1410 1000
DocumentCardTitle mount 1723 1709 1000
Dropdown mount 2420 2429 5000
FocusZone mount 1723 1691 5000
IconButton mount 1614 1630 5000
Label mount 319 323 5000
Link mount 414 422 5000
LinkNext mount 440 434 5000
MenuButton mount 1333 1366 5000
MessageBar mount 1986 1968 5000
MessageBarNext mount 1923 1907 5000
Nav mount 3026 3005 1000
OverflowSet mount 1304 1326 5000
OverflowSetNext mount 984 982 5000
Panel mount 1374 1385 1000
Persona mount 829 823 1000
Pivot mount 1345 1330 1000
PivotNext mount 1312 1287 1000
PrimaryButton mount 1176 1193 5000
Rating mount 7106 7081 5000
RatingNext mount 7031 7065 5000
SearchBox mount 1181 1166 5000
SearchBoxNext mount 1264 1218 5000
Shimmer mount 2376 2426 5000
ShimmerNext mount 2389 2350 5000
Slider mount 1434 1437 5000
SliderNext mount 1775 1788 5000
SpinButton mount 4680 4686 5000
SpinButtonNext mount 4844 4826 5000
Spinner mount 413 393 5000
SplitButton mount 2968 2970 5000
Stack mount 501 485 5000
StackWithIntrinsicChildren mount 1750 1776 5000
StackWithTextChildren mount 4612 4581 5000
SwatchColorPicker mount 9668 9743 5000
SwatchColorPickerNext mount 9664 9677 5000
TagPicker mount 2618 2567 5000
TeachingBubble mount 48163 48301 5000
TeachingBubbleNext mount 47890 48345 5000
Text mount 411 412 5000
TextField mount 1269 1299 5000
ThemeProvider mount 4654 4695 5000
ThemeProvider virtual-rerender 509 490 5000
Toggle mount 784 795 5000
ToggleNext mount 779 763 5000
button mount 98 102 5000

Perf Analysis (Fluent)

⚠️ 5 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
ButtonOverridesMissPerf.default 1618 41 39.46:1 analysis
ButtonUseCssNestingPerf.default 1019 43 23.7:1 analysis
ButtonUseCssPerf.default 802 39 20.56:1 analysis
ChatWithPopoverPerf.default 435 424 1.03:1 analysis
ListCommonPerf.default 618 884 0.7:1 analysis
Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.42 0.46 0.91:1 2000 840
🦄 Button.Fluent 0.11 0.19 0.58:1 5000 564
🔧 Checkbox.Fluent 0.61 0.33 1.85:1 1000 614
🎯 Dialog.Fluent 0.15 0.2 0.75:1 5000 749
🔧 Dropdown.Fluent 2.79 0.45 6.2:1 1000 2793
🔧 Icon.Fluent 0.14 0.06 2.33:1 5000 677
🦄 Image.Fluent 0.07 0.11 0.64:1 5000 363
🔧 Slider.Fluent 1.51 0.34 4.44:1 1000 1506
🔧 Text.Fluent 0.07 0.03 2.33:1 5000 358
🦄 Tooltip.Fluent 0.11 15.66 0.01:1 5000 545

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
PortalMinimalPerf.default 162 113 1.43:1
BoxMinimalPerf.default 388 297 1.31:1
RefMinimalPerf.default 240 191 1.26:1
GridMinimalPerf.default 351 290 1.21:1
ButtonMinimalPerf.default 172 144 1.19:1
Text.Fluent 358 302 1.19:1
FlexMinimalPerf.default 301 255 1.18:1
FormMinimalPerf.default 401 341 1.18:1
ReactionMinimalPerf.default 409 350 1.17:1
StatusMinimalPerf.default 701 600 1.17:1
AttachmentMinimalPerf.default 159 137 1.16:1
SkeletonMinimalPerf.default 416 358 1.16:1
DividerMinimalPerf.default 371 322 1.15:1
LayoutMinimalPerf.default 416 363 1.15:1
SegmentMinimalPerf.default 360 313 1.15:1
ImageMinimalPerf.default 373 327 1.14:1
Button.Fluent 564 495 1.14:1
AnimationMinimalPerf.default 411 365 1.13:1
TableMinimalPerf.default 405 358 1.13:1
TextAreaMinimalPerf.default 471 416 1.13:1
VideoMinimalPerf.default 619 550 1.13:1
Image.Fluent 363 320 1.13:1
HeaderMinimalPerf.default 365 330 1.11:1
ListMinimalPerf.default 475 429 1.11:1
RadioGroupMinimalPerf.default 423 382 1.11:1
ChatMinimalPerf.default 610 554 1.1:1
LabelMinimalPerf.default 412 373 1.1:1
TextMinimalPerf.default 344 312 1.1:1
Tooltip.Fluent 545 495 1.1:1
DialogMinimalPerf.default 764 702 1.09:1
TooltipMinimalPerf.default 783 721 1.09:1
AlertMinimalPerf.default 295 272 1.08:1
PopupMinimalPerf.default 671 621 1.08:1
TreeMinimalPerf.default 840 777 1.08:1
CardMinimalPerf.default 538 501 1.07:1
CarouselMinimalPerf.default 442 415 1.07:1
ProviderMinimalPerf.default 902 840 1.07:1
IconMinimalPerf.default 631 587 1.07:1
Avatar.Fluent 840 787 1.07:1
ButtonSlotsPerf.default 597 564 1.06:1
CheckboxMinimalPerf.default 2764 2619 1.06:1
AccordionMinimalPerf.default 142 135 1.05:1
AvatarMinimalPerf.default 449 429 1.05:1
HeaderSlotsPerf.default 756 718 1.05:1
MenuButtonMinimalPerf.default 1498 1421 1.05:1
ToolbarMinimalPerf.default 893 847 1.05:1
Dialog.Fluent 749 710 1.05:1
DropdownManyItemsPerf.default 718 689 1.04:1
ItemLayoutMinimalPerf.default 1193 1152 1.04:1
MenuMinimalPerf.default 810 777 1.04:1
SliderMinimalPerf.default 1539 1473 1.04:1
TableManyItemsPerf.default 2092 2007 1.04:1
CustomToolbarPrototype.default 3603 3470 1.04:1
Icon.Fluent 677 654 1.04:1
ChatDuplicateMessagesPerf.default 404 393 1.03:1
LoaderMinimalPerf.default 710 691 1.03:1
SplitButtonMinimalPerf.default 3605 3489 1.03:1
Checkbox.Fluent 614 594 1.03:1
AttachmentSlotsPerf.default 1086 1063 1.02:1
DropdownMinimalPerf.default 2850 2793 1.02:1
EmbedMinimalPerf.default 1821 1782 1.02:1
ProviderMergeThemesPerf.default 1900 1857 1.02:1
InputMinimalPerf.default 1240 1233 1.01:1
Slider.Fluent 1506 1498 1.01:1
Dropdown.Fluent 2793 2829 0.99:1
TreeWith60ListItems.default 204 212 0.96:1
ListWith60ListItems.default 908 1032 0.88:1
ListNestedPerf.default 554 819 0.68:1

@size-auditor
Copy link

size-auditor bot commented Sep 15, 2020 •
edited
Loading

Asset size changes

Project Bundle Baseline Size New Size Difference
office-ui-fabric-react fluentui-react-next-Breadcrumb 191.119 kB 190.923 kB BelowBaseline     -196 bytes

ExceedsTolerance Over Tolerance (1024 B) ExceedsBaseline Over Baseline BelowBaseline Below Baseline New New Deleted  Removed 1 kB = 1000 B

Baseline commit: a17c428e073721e981aaa402339d37b87fd8d385 (build)

@czearing
Merge branch 'master' of https://github.com/microsoft/fluentui into f…
a2e13cf 
…eat/moving-breadcrumb

# Conflicts:
#	packages/react-next/etc/react-next.api.md
@dzearing dzearing merged commit 7142365 into microsoft:master Sep 16, 2020
@msft-github-bot
Copy link
Contributor

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzearing dzearing dzearing approved these changes

@JasonGore JasonGore Awaiting requested review from JasonGore

@xugao xugao Awaiting requested review from xugao

Assignees
No one assigned
Labels
PR: API Modified PR: Possible Perf Regression 🐌
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@czearing @msft-github-bot @dzearing