-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: centered the indeterminate indicator inside the checkbox component #14836
fix: centered the indeterminate indicator inside the checkbox component #14836
Conversation
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Potential regressions comparing to master
Perf comparison
Perf tests with no regressions
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: ed851559770bc8aa7348ac4e93e63f17fa27c9bc (build) |
f92d105
to
2ca6da7
Compare
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 80939d5:
|
top: 50%; | ||
left: 50%; | ||
width: 50%; | ||
height: 50%; | ||
transform: translate(-50%, -50%); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you run yarn change
to generate a change report so this can be published correctly? That will help the build pass as well :).
7282684
to
80939d5
Compare
🎉 Handy links: |
Pull request checklist
$ yarn change
Description of changes
Update to center the indicator by setting top and left to 50% and shifting it up and left by half of its own width and height, because the indicator is off by a pixel.
Focus areas to test
(optional)