Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding prelint checks in PR gates #14566

Merged
merged 5 commits into from
Aug 18, 2020
Merged

Adding prelint checks in PR gates #14566

merged 5 commits into from
Aug 18, 2020

Conversation

kenotron
Copy link
Member

@kenotron kenotron commented Aug 17, 2020 •
edited
Loading

Description of changes

Adding a prelint check for the PR gates: we used to rely on the run behavior for the repo wide "lint" command. This was triggered BEFORE the lerna call. Now we folded that into lage which calls build, test and lint together (intertwined). So the pre-lint script was not triggered.

This is the relevant script:

"prelint": "yarn satisfied && yarn syncpack:list-mismatches && node ./scripts/no-tslint.js",

Focus areas to test

(optional)

@kenotron kenotron requested a review from ecraig12345 as a code owner August 17, 2020 18:00
@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 17, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c954579:

Sandbox Source
Fluent UI Button Configuration
microsoft/fluentui: codesandbox-react-template Configuration
microsoft/fluentui: codesandbox-react-next-template Configuration
microsoft/fluentui: codesandbox-react-northstar-template Configuration

@size-auditor
Copy link

size-auditor bot commented Aug 17, 2020 •
edited
Loading

Asset size changes

⚠️ Insufficient baseline data to detect size changes

Unable to find bundle size details for Baseline commit: 298f84c

Possible causes

  • The baseline build 298f84c is broken
  • The Size Auditor run for the baseline build 298f84c was not triggered

Recommendations

  • Please merge your branch for this Pull request with the latest master build and commit your changes once again

@msft-github-bot
Copy link
Contributor

msft-github-bot commented Aug 17, 2020 •
edited
Loading

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 843 823 5000
ButtonNext mount 568 563 5000
Checkbox mount 1497 1495 5000
CheckboxBase mount 1303 1252 5000
CheckboxNext mount 1673 1608 5000
ChoiceGroup mount 4719 4813 5000
ComboBox mount 943 916 1000
CommandBar mount 6978 7034 1000
ContextualMenu mount 12491 12466 1000
DefaultButton mount 1046 1067 5000
DetailsRow mount 3359 3265 5000
DetailsRowFast mount 3375 3396 5000
DetailsRowNoStyles mount 3207 3325 5000
Dialog mount 1399 1418 1000
DocumentCardTitle mount 1742 1706 1000
Dropdown mount 2521 2401 5000
FocusZone mount 1697 1747 5000
IconButton mount 1722 1596 5000
Label mount 326 325 5000
Link mount 438 387 5000
LinkNext mount 431 484 5000
MenuButton mount 1372 1390 5000
Nav mount 3036 2988 1000
Panel mount 1331 1398 1000
Persona mount 771 786 1000
Pivot mount 1354 1302 1000
PivotNext mount 1290 1337 1000
PrimaryButton mount 1191 1187 5000
SearchBox mount 1231 1152 5000
SearchBoxNext mount 1218 1204 5000
Slider mount 1369 1374 5000
SliderNext mount 1737 1748 5000
SpinButton mount 4739 4667 5000
SpinButtonNext mount 4635 4707 5000
Spinner mount 402 417 5000
SplitButton mount 2972 2869 5000
Stack mount 505 509 5000
StackWithIntrinsicChildren mount 1808 1839 5000
StackWithTextChildren mount 4714 4725 5000
TagPicker mount 2549 2532 5000
Text mount 384 384 5000
TextField mount 1300 1230 5000
ThemeProvider mount 2675 2738 5000
ThemeProvider virtual-rerender 417 421 5000
Toggle mount 787 817 5000
ToggleNext mount 760 810 5000
button mount 106 107 5000

Perf Analysis (Fluent)

⚠️ 3 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
ButtonOverridesMissPerf.default 111 43 2.58:1 analysis
ButtonUseCssPerf.default 59 44 1.34:1 analysis
ListCommonPerf.default 608 849 0.72:1 analysis
Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.41 0.43 0.95:1 2000 822
🦄 Button.Fluent 0.1 0.17 0.59:1 5000 513
🔧 Checkbox.Fluent 0.61 0.32 1.91:1 1000 612
🎯 Dialog.Fluent 0.14 0.2 0.7:1 5000 676
🔧 Dropdown.Fluent 2.82 0.43 6.56:1 1000 2815
🔧 Icon.Fluent 0.12 0.05 2.4:1 5000 614
🎯 Image.Fluent 0.07 0.1 0.7:1 5000 329
🔧 Slider.Fluent 1.5 0.33 4.55:1 1000 1504
🔧 Text.Fluent 0.06 0.03 2:1 5000 307
🦄 Tooltip.Fluent 0.1 15.81 0.01:1 5000 475

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
PortalMinimalPerf.default 125 107 1.17:1
AlertMinimalPerf.default 288 252 1.14:1
ProviderMinimalPerf.default 936 838 1.12:1
ButtonMinimalPerf.default 171 156 1.1:1
HeaderMinimalPerf.default 340 309 1.1:1
Checkbox.Fluent 612 554 1.1:1
BoxMinimalPerf.default 315 289 1.09:1
DividerMinimalPerf.default 354 324 1.09:1
ChatDuplicateMessagesPerf.default 415 388 1.07:1
ReactionMinimalPerf.default 353 330 1.07:1
SkeletonMinimalPerf.default 373 348 1.07:1
VideoMinimalPerf.default 568 530 1.07:1
HeaderSlotsPerf.default 720 678 1.06:1
Button.Fluent 513 484 1.06:1
Image.Fluent 329 309 1.06:1
CardMinimalPerf.default 518 494 1.05:1
DropdownManyItemsPerf.default 700 664 1.05:1
FlexMinimalPerf.default 252 240 1.05:1
LayoutMinimalPerf.default 365 348 1.05:1
ProviderMergeThemesPerf.default 1834 1749 1.05:1
RadioGroupMinimalPerf.default 392 372 1.05:1
ChatWithPopoverPerf.default 463 444 1.04:1
EmbedMinimalPerf.default 1791 1724 1.04:1
MenuMinimalPerf.default 805 771 1.04:1
TableMinimalPerf.default 355 341 1.04:1
Avatar.Fluent 822 788 1.04:1
CarouselMinimalPerf.default 436 423 1.03:1
CheckboxMinimalPerf.default 2651 2575 1.03:1
DialogMinimalPerf.default 709 690 1.03:1
ImageMinimalPerf.default 329 319 1.03:1
SliderMinimalPerf.default 1501 1457 1.03:1
IconMinimalPerf.default 630 609 1.03:1
TextAreaMinimalPerf.default 415 403 1.03:1
CustomToolbarPrototype.default 3674 3583 1.03:1
Dropdown.Fluent 2815 2741 1.03:1
AnimationMinimalPerf.default 356 349 1.02:1
AvatarMinimalPerf.default 452 445 1.02:1
DropdownMinimalPerf.default 2826 2771 1.02:1
LabelMinimalPerf.default 367 359 1.02:1
StatusMinimalPerf.default 615 600 1.02:1
TextMinimalPerf.default 313 308 1.02:1
ToolbarMinimalPerf.default 877 857 1.02:1
Text.Fluent 307 302 1.02:1
AttachmentMinimalPerf.default 145 143 1.01:1
AttachmentSlotsPerf.default 1103 1097 1.01:1
ButtonSlotsPerf.default 550 544 1.01:1
ChatMinimalPerf.default 562 557 1.01:1
GridMinimalPerf.default 305 301 1.01:1
InputMinimalPerf.default 1226 1215 1.01:1
ItemLayoutMinimalPerf.default 1177 1162 1.01:1
PopupMinimalPerf.default 628 620 1.01:1
RefMinimalPerf.default 190 189 1.01:1
SegmentMinimalPerf.default 312 310 1.01:1
SplitButtonMinimalPerf.default 3471 3442 1.01:1
Icon.Fluent 614 608 1.01:1
Tooltip.Fluent 475 471 1.01:1
Dialog.Fluent 676 678 1:1
Slider.Fluent 1504 1510 1:1
AccordionMinimalPerf.default 132 133 0.99:1
LoaderMinimalPerf.default 690 698 0.99:1
TreeWith60ListItems.default 194 196 0.99:1
MenuButtonMinimalPerf.default 1429 1459 0.98:1
TableManyItemsPerf.default 1967 1999 0.98:1
TreeMinimalPerf.default 780 794 0.98:1
TooltipMinimalPerf.default 706 732 0.96:1
ButtonUseCssNestingPerf.default 41 43 0.95:1
FormMinimalPerf.default 348 365 0.95:1
ListMinimalPerf.default 413 444 0.93:1
ListWith60ListItems.default 889 970 0.92:1
ListNestedPerf.default 556 789 0.7:1

@kenotron kenotron merged commit 88c5b45 into microsoft:master Aug 18, 2020
@kenotron kenotron deleted the prelint branch August 18, 2020 02:43
@msft-github-bot
Copy link
Contributor

🎉@uifabric/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@uifabric/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@uifabric/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@uifabric/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@uifabric/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@uifabric/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@uifabric/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@uifabric/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@uifabric/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@uifabric/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@uifabric/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@uifabric/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@uifabric/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@uifabric/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

levithomason pushed a commit to levithomason/fluentui that referenced this pull request Aug 24, 2020
@kenotron @levithomason
Adding prelint checks in PR gates (microsoft#14566)
27aba3e 
* adding prelint checks

* fixing publish

* Change files

* fix change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khmakoto khmakoto khmakoto approved these changes

@ecraig12345 ecraig12345 ecraig12345 approved these changes

@wsmd wsmd wsmd approved these changes

@xugao xugao xugao approved these changes

@chrisdholt chrisdholt Awaiting requested review from chrisdholt

@dzearing dzearing Awaiting requested review from dzearing

@hyoshis hyoshis Awaiting requested review from hyoshis

@Jacqueline-ms Jacqueline-ms Awaiting requested review from Jacqueline-ms Jacqueline-ms is a code owner

@aditima aditima Awaiting requested review from aditima

@dvdzkwsk dvdzkwsk Awaiting requested review from dvdzkwsk

@evlevy evlevy Awaiting requested review from evlevy

@Jahnp Jahnp Awaiting requested review from Jahnp

@JasonGore JasonGore Awaiting requested review from JasonGore

@jurokapsiar jurokapsiar Awaiting requested review from jurokapsiar

@layershifter layershifter Awaiting requested review from layershifter

@levithomason levithomason Awaiting requested review from levithomason

@lorejoh12 lorejoh12 Awaiting requested review from lorejoh12

@miroslavstastny miroslavstastny Awaiting requested review from miroslavstastny

@mnajdova mnajdova Awaiting requested review from mnajdova

@pompomon pompomon Awaiting requested review from pompomon

@Raghurk Raghurk Awaiting requested review from Raghurk

Assignees

@khmakoto khmakoto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kenotron @msft-github-bot @xugao @wsmd @ecraig12345 @khmakoto