Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codemods: Implement Result and prepare for logging update. #14548

Merged
merged 4 commits into from
Aug 17, 2020
Merged

Codemods: Implement Result and prepare for logging update. #14548

merged 4 commits into from
Aug 17, 2020

Conversation

joschect
Copy link
Contributor

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

(give an overview)

Focus areas to test

(optional)

@joschect joschect requested a review from jdhuntington August 15, 2020 19:36
@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 15, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 30e0401:

Sandbox Source
Fluent UI Button Configuration
microsoft/fluentui: codesandbox-react-template Configuration
microsoft/fluentui: codesandbox-react-next-template Configuration
microsoft/fluentui: codesandbox-react-northstar-template Configuration

@msft-github-bot
Copy link
Contributor

msft-github-bot commented Aug 15, 2020 •
edited
Loading

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 908 878 5000
ButtonNext mount 571 575 5000
Checkbox mount 1568 1647 5000
CheckboxBase mount 1271 1303 5000
CheckboxNext mount 1718 1636 5000
ChoiceGroup mount 4867 4946 5000
ComboBox mount 909 923 1000
CommandBar mount 7550 7564 1000
ContextualMenu mount 13540 13343 1000
DefaultButton mount 1072 1068 5000
DetailsRow mount 3577 3558 5000
DetailsRowFast mount 3679 3522 5000
DetailsRowNoStyles mount 3567 3441 5000
Dialog mount 1538 1519 1000
DocumentCardTitle mount 1866 1868 1000
Dropdown mount 2716 2727 5000
FocusZone mount 1919 1869 5000
IconButton mount 1722 1764 5000
Label mount 359 353 5000
Link mount 452 441 5000
LinkNext mount 493 490 5000
MenuButton mount 1429 1437 5000
Nav mount 3209 3231 1000
Panel mount 1432 1484 1000
Persona mount 853 842 1000
Pivot mount 1391 1375 1000
PivotNext mount 1382 1398 1000
PrimaryButton mount 1264 1250 5000
SearchBox mount 1280 1275 5000
SearchBoxNext mount 1306 1311 5000
Slider mount 1486 1459 5000
SliderNext mount 1922 1889 5000
SpinButton mount 4956 4837 5000
SpinButtonNext mount 5435 5030 5000
Spinner mount 429 417 5000
SplitButton mount 3217 3142 5000
Stack mount 526 520 5000
StackWithIntrinsicChildren mount 1945 1962 5000
StackWithTextChildren mount 4976 4972 5000
TagPicker mount 2783 2644 5000
Text mount 422 445 5000
TextField mount 1374 1364 5000
ThemeProvider mount 2978 2777 5000
ThemeProvider virtual-rerender 448 472 5000
Toggle mount 818 832 5000
ToggleNext mount 853 828 5000
button mount 124 127 5000

Perf Analysis (Fluent)

⚠️ 2 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
ButtonOverridesMissPerf.default 106 44 2.41:1 analysis
ListCommonPerf.default 644 950 0.68:1 analysis
Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.44 0.47 0.94:1 2000 879
🦄 Button.Fluent 0.1 0.19 0.53:1 5000 517
🔧 Checkbox.Fluent 0.62 0.36 1.72:1 1000 624
🦄 Dialog.Fluent 0.15 0.22 0.68:1 5000 743
🔧 Dropdown.Fluent 2.97 0.47 6.32:1 1000 2973
🔧 Icon.Fluent 0.14 0.06 2.33:1 5000 703
🦄 Image.Fluent 0.07 0.11 0.64:1 5000 362
🔧 Slider.Fluent 1.6 0.37 4.32:1 1000 1600
🔧 Text.Fluent 0.06 0.03 2:1 5000 323
🦄 Tooltip.Fluent 0.1 19.02 0.01:1 5000 516

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ButtonUseCssPerf.default 62 40 1.55:1
ButtonUseCssNestingPerf.default 63 45 1.4:1
AccordionMinimalPerf.default 157 129 1.22:1
ButtonMinimalPerf.default 182 164 1.11:1
Image.Fluent 362 332 1.09:1
RadioGroupMinimalPerf.default 424 393 1.08:1
TableMinimalPerf.default 408 379 1.08:1
FlexMinimalPerf.default 283 264 1.07:1
LabelMinimalPerf.default 402 380 1.06:1
SkeletonMinimalPerf.default 406 384 1.06:1
IconMinimalPerf.default 650 612 1.06:1
CarouselMinimalPerf.default 467 445 1.05:1
ProviderMergeThemesPerf.default 2020 1917 1.05:1
ProviderMinimalPerf.default 962 916 1.05:1
RefMinimalPerf.default 209 199 1.05:1
TreeMinimalPerf.default 878 837 1.05:1
TextMinimalPerf.default 342 328 1.04:1
TextAreaMinimalPerf.default 449 433 1.04:1
CustomToolbarPrototype.default 3835 3691 1.04:1
Avatar.Fluent 879 847 1.04:1
Icon.Fluent 703 677 1.04:1
AnimationMinimalPerf.default 391 379 1.03:1
AvatarMinimalPerf.default 476 460 1.03:1
ChatWithPopoverPerf.default 473 458 1.03:1
InputMinimalPerf.default 1339 1305 1.03:1
LoaderMinimalPerf.default 743 720 1.03:1
TooltipMinimalPerf.default 781 760 1.03:1
Text.Fluent 323 313 1.03:1
BoxMinimalPerf.default 336 330 1.02:1
ButtonSlotsPerf.default 586 577 1.02:1
DropdownMinimalPerf.default 2976 2932 1.02:1
GridMinimalPerf.default 338 333 1.02:1
HeaderMinimalPerf.default 344 336 1.02:1
MenuButtonMinimalPerf.default 1547 1522 1.02:1
PopupMinimalPerf.default 656 646 1.02:1
AlertMinimalPerf.default 293 291 1.01:1
AttachmentMinimalPerf.default 157 155 1.01:1
CardMinimalPerf.default 531 525 1.01:1
CheckboxMinimalPerf.default 2820 2801 1.01:1
DialogMinimalPerf.default 752 743 1.01:1
EmbedMinimalPerf.default 1901 1886 1.01:1
ItemLayoutMinimalPerf.default 1258 1240 1.01:1
SliderMinimalPerf.default 1618 1606 1.01:1
StatusMinimalPerf.default 660 652 1.01:1
TableManyItemsPerf.default 2148 2128 1.01:1
ToolbarMinimalPerf.default 921 912 1.01:1
VideoMinimalPerf.default 585 583 1:1
Checkbox.Fluent 624 621 1:1
Dropdown.Fluent 2973 2969 1:1
Slider.Fluent 1600 1595 1:1
Tooltip.Fluent 516 517 1:1
AttachmentSlotsPerf.default 1103 1116 0.99:1
ChatMinimalPerf.default 567 575 0.99:1
DropdownManyItemsPerf.default 786 793 0.99:1
FormMinimalPerf.default 386 390 0.99:1
ListMinimalPerf.default 459 462 0.99:1
MenuMinimalPerf.default 833 841 0.99:1
PortalMinimalPerf.default 124 125 0.99:1
SegmentMinimalPerf.default 329 331 0.99:1
SplitButtonMinimalPerf.default 3736 3755 0.99:1
Dialog.Fluent 743 748 0.99:1
LayoutMinimalPerf.default 375 381 0.98:1
ReactionMinimalPerf.default 368 376 0.98:1
Button.Fluent 517 527 0.98:1
ChatDuplicateMessagesPerf.default 420 431 0.97:1
ImageMinimalPerf.default 340 351 0.97:1
HeaderSlotsPerf.default 743 773 0.96:1
DividerMinimalPerf.default 346 388 0.89:1
ListWith60ListItems.default 955 1084 0.88:1
TreeWith60ListItems.default 185 212 0.87:1
ListNestedPerf.default 583 863 0.68:1

@size-auditor
Copy link

size-auditor bot commented Aug 17, 2020 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: f550420c490b22b50b543204447efa7802b37b60 (build)

@joschect joschect closed this Aug 17, 2020
@joschect joschect reopened this Aug 17, 2020
@joschect joschect merged commit 160f614 into microsoft:master Aug 17, 2020
@msft-github-bot
Copy link
Contributor

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

levithomason pushed a commit to levithomason/fluentui that referenced this pull request Aug 24, 2020
@joschect @levithomason
Codemods: Implement Result and prepare for logging update. (microsoft…
6e17202 
…#14548)

* result implemented

* add logger interface

* tweak no op result

* Change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdhuntington jdhuntington jdhuntington approved these changes

Assignees

@khmakoto khmakoto

Labels
Area: Build System Package: codemods
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joschect @msft-github-bot @jdhuntington @khmakoto