T dama/CodeMods - Add generic config-based codemod generator #14496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
August 12, 2020 18:31
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit abde9f2:
|
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Asset size changesUnable to find bundle size details for Baseline commit: a121562 Possible causes
Recommendations
|
joschect
approved these changes
Aug 14, 2020
|
🎉 Handy links: |
levithomason
pushed a commit
to levithomason/fluentui
that referenced
this pull request
Aug 24, 2020
…ft#14496) * merge conflicts * merge conflicts * merge conflicts * merge conflicts * fix prop helper * merge conflicts * WIP improve logging * merge conflicts * merge conflicts * merge conflicts * merge conflicts * WIP polishing * remove logging * add generic config mod * Change files * fix test * add snapshot testing * add snapshot * improve logging * new snaps * fix tests Co-authored-by: Trip Master <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Added configMod.ts, which can read a codemod from a json file and return it. Take a look at upgrades.json for a sample upgrade file! Added simple testing for it too, which sets a nice precedent for testing actual codemods w/ jest and not just utilities
-Hopefully this middle ground between mod and json can also be leveraged / generalized further to add more flexibility at a high level for developers.
-TODO: Add support for more codemods -- adding support for new ones shouldn't be too tricky -- a dev just needs to set a standard for what upgrades.json should look like, and then parse that into a series of functions that can be stored. Check out getCodeModUtilitiesFromJson for more deets.