-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dropdown: Removing aria-required from multiselect scenarios since it's not allowed for role='button' #14369
Dropdown: Removing aria-required from multiselect scenarios since it's not allowed for role='button' #14369
Conversation
…s not allowed for role='button'.
@msft-github-bot merge in 1 minute |
Hello @khmakoto! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4916bfe:
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b47a230:
|
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Asset size changes
Over Tolerance (1024 B) Over Baseline Below Baseline New Removed 1 kB = 1000 B Baseline commit: c8bb1d97af900f52e46aba43cad1c6b51f5b6377 (build) |
🎉 Handy links: |
) #### Pull request checklist - [ ] Addresses an existing issue: Fixes #0000 - [x] Include a change request file using `$ yarn change` #### Description of changes This PR is a port of fixes #14367 and #14369 done in `office-ui-fabric-react` to `@fluentui/react-next`. #### Focus areas to test (optional)
…s not allowed for role='button' (microsoft#14369) #### Pull request checklist - [x] Addresses an existing issue: Fixes microsoft#14355 - [x] Include a change request file using `$ yarn change` #### Description of changes We were placing `aria-required` on `Dropdowns`, but this clashed with the `role='button'` we were placing on multiselect `Dropdowns` and creating accessibility warnings. We're fixing this issue by setting `aria-required` only for single select `Dropdowns`. #### Focus areas to test (optional)
…rosoft#14377) #### Pull request checklist - [ ] Addresses an existing issue: Fixes #0000 - [x] Include a change request file using `$ yarn change` #### Description of changes This PR is a port of fixes microsoft#14367 and microsoft#14369 done in `office-ui-fabric-react` to `@fluentui/react-next`. #### Focus areas to test (optional)
Pull request checklist
$ yarn change
Description of changes
We were placing
aria-required
onDropdowns
, but this clashed with therole='button'
we were placing on multiselectDropdowns
and creating accessibility warnings. We're fixing this issue by settingaria-required
only for single selectDropdowns
.Focus areas to test
(optional)