Skip to content

Commit

Permalink
addressed feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
eljefe223 committed Jul 25, 2024
1 parent 8fb7fae commit e766283
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 21 deletions.
4 changes: 2 additions & 2 deletions packages/web-components/docs/api-report.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ export type AccordionExpandMode = ValuesOf<typeof AccordionExpandMode>;
//
// @public
export class AccordionItem extends BaseAccordionItem {
block: boolean;
blockChanged(prev: boolean, next: boolean): void;
markerPosition?: AccordionItemMarkerPosition;
markerPositionChanged(prev: AccordionItemMarkerPosition, next: AccordionItemMarkerPosition): void;
size?: AccordionItemSize;
Expand Down Expand Up @@ -426,8 +428,6 @@ export const BadgeTemplate: ElementViewTemplate<Badge>;

// @public (undocumented)
export class BaseAccordionItem extends FASTElement {
block: boolean;
blockChanged(prev: boolean, next: boolean): void;
disabled: boolean;
disabledChanged(prev: boolean, next: boolean): void;
// @internal
Expand Down
38 changes: 19 additions & 19 deletions packages/web-components/src/accordion-item/accordion-item.ts
Original file line number Diff line number Diff line change
Expand Up @@ -100,25 +100,6 @@ export class BaseAccordionItem extends FASTElement {
@attr
public id: string = uniqueId('accordion-');

/**
* Sets the width of the focus state.
*
* @public
* @remarks
* HTML Attribute: block
*/
@attr({ mode: 'boolean' })
public block: boolean = false;

/**
* Handles changes to block attribute
* @param prev - previous value
* @param next - next value
*/
public blockChanged(prev: boolean, next: boolean): void {
toggleState(this.elementInternals, 'block', next);
}

/**
* @internal
*/
Expand Down Expand Up @@ -179,6 +160,25 @@ export class AccordionItem extends BaseAccordionItem {
toggleState(this.elementInternals, `align-${next}`, true);
}
}

/**
* Sets the width of the focus state.
*
* @public
* @remarks
* HTML Attribute: block
*/
@attr({ mode: 'boolean' })
public block: boolean = false;

/**
* Handles changes to block attribute
* @param prev - previous value
* @param next - next value
*/
public blockChanged(prev: boolean, next: boolean): void {
toggleState(this.elementInternals, 'block', next);
}
}

/**
Expand Down

0 comments on commit e766283

Please sign in to comment.