Prevent group toggling from selecting the whole group (#24822)

* Ensure toggling group state does not select it * Update changelogs * Update snapshots
microsoft · Sep 15, 2022 · 9077e0a · 9077e0a
1 parent 151520d
commit 9077e0a
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 0 deletions.
diff --git a/change/@fluentui-react-ab3b8086-f406-44cd-bef5-7782fdef2863.json b/change/@fluentui-react-ab3b8086-f406-44cd-bef5-7782fdef2863.json
@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "Ensure toggling group state does not select it",
+  "packageName": "@fluentui/react",
+  "email": "[email protected]",
+  "dependentChangeType": "patch"
+}
diff --git a/packages/react/src/components/DetailsList/__snapshots__/DetailsList.test.tsx.snap b/packages/react/src/components/DetailsList/__snapshots__/DetailsList.test.tsx.snap
@@ -7951,6 +7951,7 @@ exports[`DetailsList renders List with hidden checkboxes correctly 1`] = `
                                     background-color: #e1dfdd;
                                   }
                               data-is-focusable={false}
+                              data-selection-disabled={true}
                               onClick={[Function]}
                               type="button"
                             >
@@ -8812,6 +8813,7 @@ exports[`DetailsList renders List with hidden checkboxes correctly 1`] = `
                                     background-color: #e1dfdd;
                                   }
                               data-is-focusable={false}
+                              data-selection-disabled={true}
                               onClick={[Function]}
                               type="button"
                             >

diff --git a/packages/react/src/components/GroupedList/GroupHeader.base.tsx b/packages/react/src/components/GroupedList/GroupHeader.base.tsx
@@ -165,6 +165,7 @@ export class GroupHeaderBase extends React.Component<IGroupHeaderProps, IGroupHe
           <div role="gridcell">
             <button
               data-is-focusable={false}
+              data-selection-disabled={true}
               type="button"
               className={this._classNames.expand}
               onClick={this._onToggleClick}