Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[a11y] Extend DemoController's alert auto-dismiss delay when vo is on #2123

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

joannaquu
Copy link
Contributor

@joannaquu joannaquu commented Jan 30, 2025

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

DemoController's showMessage has an auto dismiss option of 1 second. When voice over is running, this is too fast and ends up dismissing the alert before the alert message can be read. Update it to be 3 seconds when vo is on.

Verification

Before After
https://github.com/user-attachments/assets/1edbf183-88e5-4ed9-a377-5e29244929dc https://github.com/user-attachments/assets/cba02757-3d3d-4325-9a65-ebaafcc042a2

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@joannaquu joannaquu requested a review from a team as a code owner January 30, 2025 00:42
@joannaquu joannaquu merged commit 082072c into microsoft:main Jan 30, 2025
7 checks passed
@joannaquu joannaquu deleted the joannaqu/alert-vo branch January 30, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants