This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(Toolbar): ToolbarMenuItem doesn't focus menu trigger element after 'onClick' was executed #2367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolaps33
requested review from
dvdzkwsk,
dzearing,
ecraig12345,
JasonGore,
jdhuntington,
kenotron,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
kolaps33
changed the title
|
Can we add a E2E/Unit test for this? |
jurokapsiar
reviewed
Feb 17, 2020
| @@ -9,6 +9,7 @@ const doList = [ | |||
| `aria-labelledby` props). Refer to{' '} | |||
| {link('toolbar(role)', 'https://www.w3.org/WAI/PF/aria/roles#toolbar')} for details. | |||
| </Text>, | |||
| 'If `Toolbar` contains menu, then focus will need be handled after `onClick` is executed on `menuItem`.' | |||
There was a problem hiding this comment.
'If Toolbar contains menu, the menu closes after clicking on one of the menu items. To prevent losing focus, move it manually in the onClick handler.
Perf comparison
Perf tests with no regressions
Generated by 🚫 dangerJS |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the issue:
#2249
Fixes #2249