Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait to be able to connect to integration test DB before running tests #498

Merged

Conversation

johnstairs
Copy link
Member

We've seen integration tests fail in PR/CI where connecting to the Azure SQL database we create on the fly does not work right away.
Now in the fixture, we check in a retry loop that we can connect to the database before proceeding.

@johnstairs johnstairs requested a review from brandonpollett May 25, 2019 18:55
@johnstairs johnstairs changed the title Wair to be able to connect to integration test DB before running tests Wait to be able to connect to integration test DB before running tests May 25, 2019
@johnstairs johnstairs merged commit 64c068e into master May 28, 2019
@johnstairs johnstairs deleted the personal/johnstairs/sql-integration-test-reliability branch June 7, 2019 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants