Test stabilization: set modelinfo provider in assembly fixture #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonpollett
approved these changes
May 21, 2019
brendankowitz
approved these changes
May 21, 2019
johnstairs
deleted the
personal/johnstairs/set-modelinfoprovider-in-assembly-fixture
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a temporary workaround to stabilize unit tests after the STU3 refactoring. Extends our xUnit extension to include a
TestFixtureAttribute, which allows a type to be created before any test executes (and disposed at the end). There is a sample for how to create such an extension in the xUnit repo.We then use this attribute to define a assembly fixture that sets the model info provider.
This should become unnecessary as the STU3/R4 work advances.
Related issues
Addresses #480