Revert: Add new SQL hash calculation #4770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cb53a35.
LTA-Thinking
added
Bug
mikaelweave
approved these changes
Jan 14, 2025
LTA-Thinking
changed the title
LTA-Thinking
deleted the
revert-4737-personal/rojo/fix-sql-parameter-hash
branch
LTA-Thinking
pushed a commit
that referenced
this pull request
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #4737
The hashes aren't working as intended. The HashCode class has a seed that changes on restart, so the hashes aren't consistent.
Bug 131113: SQL query hashes have parameter value hashes included