Add _before parameter to History search #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackliums
reviewed
May 8, 2019
src/Microsoft.Health.Fhir.Core/Features/Search/SearchService.cs
Outdated
Show resolved
Hide resolved
jackliums
reviewed
May 8, 2019
src/Microsoft.Health.Fhir.Core/Features/Search/SearchService.cs
Outdated
Show resolved
Hide resolved
jackliums
reviewed
May 8, 2019
src/Microsoft.Health.Fhir.Core/Features/Search/SearchService.cs
Outdated
Show resolved
Hide resolved
jackliums
reviewed
May 8, 2019
src/Microsoft.Health.Fhir.Core/Features/Search/BundleFactory.cs
Outdated
Show resolved
Hide resolved
feordin
force-pushed
the
personal/jaerwin/history-before
branch
from
7c91f84 to
373db47
Compare
hansenms
reviewed
May 9, 2019
src/Microsoft.Health.Fhir.Core/Features/Search/SearchService.cs
Outdated
Show resolved
Hide resolved
jackliums
reviewed
May 13, 2019
| @@ -221,10 +222,11 @@ public async Task<IActionResult> Read(string type, string id) | |||
| public async Task<IActionResult> SystemHistory( | |||
| [FromQuery(Name = KnownQueryParameterNames.At)] PartialDateTime at, | |||
There was a problem hiding this comment.
Not your code, but I just realized that the at parasmeter is an instant type. Filed new bug for this.
jackliums
reviewed
May 13, 2019
| @@ -157,7 +157,7 @@ public async Task GivenAMissingResourceId_WhenSearchingHistory_ThenAResourceNotF | |||
|
|
|||
| _searchService.SearchImplementation = options => new SearchResult(new ResourceWrapper[0], null); | |||
|
|
|||
| await Assert.ThrowsAsync<ResourceNotFoundException>(() => _searchService.SearchHistoryAsync(resourceType, resourceId, null, null, null, null, CancellationToken.None)); | |||
| await Assert.ThrowsAsync<ResourceNotFoundException>(() => _searchService.SearchHistoryAsync(resourceType, resourceId, null, null, null, null, null, CancellationToken.None)); | |||
There was a problem hiding this comment.
nit: can we add named parameter for readability?
feordin
changed the title
…ts to be more stable/reliable.
feordin
force-pushed
the
personal/jaerwin/history-before
branch
from
d355fbe to
e1a0394
Compare
… the tests unreliable.
brendankowitz
approved these changes
May 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for a new parameter: _before, for history searches
Related issues
Addresses [issue AB#68975].
Testing
Created several new E2E tests for history covering different values for _since and _before with different number of updates in history