Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit log valid claims by default for AAD vs. IdentityServer #386

Merged
merged 2 commits into from
Mar 15, 2019

Conversation

cunninghamjc
Copy link
Member

@cunninghamjc cunninghamjc commented Mar 14, 2019

Description

Updated the default LastModifiedClaims setting to oid for AAD, and updated test/local deployments to appid for IdentityServer.

Related issues

Addresses #387 .

Testing

Manually verified local deployments have LastModifiedClaims = appid.
Manually verified in App Insights that audit logs from the PR deployment contain oid.

@cunninghamjc cunninghamjc marked this pull request as ready for review March 15, 2019 05:09
@cunninghamjc cunninghamjc merged commit 36e6a4c into master Mar 15, 2019
@cunninghamjc cunninghamjc deleted the personal/cunninghamjc/audit-claims branch March 15, 2019 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants