-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add skeleton support for $export operation #382
Conversation
…ionsController handling a single hardcoded route (/$export)
…outes we need to support along with the corresponding action methods.
…eption filter to OperationController
src/Microsoft.Health.Fhir.Api/Controllers/OperationsController.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Fhir.Api/Controllers/OperationsController.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Fhir.Api/Controllers/OperationsController.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Fhir.Api/Controllers/OperationsController.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Fhir.Api/Controllers/OperationsController.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Fhir.Api/Features/Filters/ValidateExportHeadersFilterAttribute.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Fhir.Api/Features/Filters/ValidateExportHeadersFilterAttribute.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Fhir.Api/Features/Filters/ValidateExportHeadersFilterAttribute.cs
Outdated
Show resolved
Hide resolved
exporttestconfiguration.json
Outdated
@@ -0,0 +1,7 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move these json files to ./test/configuration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since moving the testauthenvironment.json might not be straightforward (might have to update corresponding PS scripts that use the file), it think it would be better to do it in a separate follow-up PR. Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible at least to move the cors and export configuration.json file into ./test/configuration as suggested? That way, we can also update the build script to copy the folder as opposed to individual files. We can then migrate the testauthenvironment.json later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved it to test/configuration and updated the build pipeline
src/Microsoft.Health.Fhir.Api.UnitTests/Controllers/ExportControllerTests.cs
Outdated
Show resolved
Hide resolved
… instead of SupportsExport. Addressed other PR comments.
…peration failures throw that.
src/Microsoft.Health.Fhir.Api.UnitTests/Controllers/ExportControllerTests.cs
Show resolved
Hide resolved
src/Microsoft.Health.Fhir.Api/Features/Filters/ValidateExportHeadersFilterAttribute.cs
Outdated
Show resolved
Hide resolved
…onding audit type. Addressed other PR comments
…rt as a sub-section under Operations.
src/Microsoft.Health.Fhir.Api/Features/Filters/ValidateExportHeadersFilterAttribute.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Fhir.Api/Features/Filters/ValidateExportHeadersFilterAttribute.cs
Outdated
Show resolved
Hide resolved
44a2353
to
c17807e
Compare
Description
This change just adds the initial framework for supporting $export operations.
BadRequest
orNotImplemented
.Related issues
Addresses [issue #342 ].
Testing
UTs have been added for the controller and filter attribute.
E2E tests