Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skeleton support for $export operation #382

Merged
merged 34 commits into from
Apr 10, 2019

Conversation

namadabu
Copy link
Contributor

@namadabu namadabu commented Mar 8, 2019

Description

This change just adds the initial framework for supporting $export operations.

  • Added a separate OperationsController to handle requests related to operations. Currently it just handled export operation request, but might expand in the future depending on what operations we might support.
  • Added 3 export routes and the corresponding action methods. Currently they just do some validation and return either BadRequest or NotImplemented.
  • Added a filter attribute to validate the Accept and Prefer headers for export requests.
  • Added a feature flag to enable to disable export operations for the fhir-server

Related issues

Addresses [issue #342 ].

Testing

UTs have been added for the controller and filter attribute.
E2E tests

@namadabu namadabu marked this pull request as ready for review March 11, 2019 16:35
@@ -0,0 +1,7 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move these json files to ./test/configuration?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since moving the testauthenvironment.json might not be straightforward (might have to update corresponding PS scripts that use the file), it think it would be better to do it in a separate follow-up PR. Thoughts?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible at least to move the cors and export configuration.json file into ./test/configuration as suggested? That way, we can also update the build script to copy the folder as opposed to individual files. We can then migrate the testauthenvironment.json later?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved it to test/configuration and updated the build pipeline

@namadabu namadabu requested a review from jackliums March 13, 2019 17:46
build/package.yml Outdated Show resolved Hide resolved
src/Microsoft.Health.Fhir.Api/Resources.resx Outdated Show resolved Hide resolved
src/Microsoft.Health.Fhir.Web/appsettings.json Outdated Show resolved Hide resolved
@namadabu namadabu force-pushed the personal/namadabu/add-export-route branch from 44a2353 to c17807e Compare April 9, 2019 00:23
@namadabu namadabu merged commit 9ff4e17 into master Apr 10, 2019
@namadabu namadabu deleted the personal/namadabu/add-export-route branch April 10, 2019 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants