Force specific SDK and runtime versions. #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/Microsoft.Health.Fhir.Tests.E2E/Microsoft.Health.Fhir.Tests.E2E.csproj
Show resolved
Hide resolved
brendankowitz
approved these changes
Mar 6, 2019
test/Microsoft.Health.Fhir.Tests.E2E/Microsoft.Health.Fhir.Tests.E2E.csproj
Show resolved
Hide resolved
…/github.com/Microsoft/fhir-server into personal/jostairs/deterministic-sdk-version
brandonpollett
approved these changes
Mar 7, 2019
…/github.com/Microsoft/fhir-server into personal/jostairs/deterministic-sdk-version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
.NET runtime version 2.2.2 has a bug that breaks our end to end tests when run locally. So we want to make sure to use 2.2.1.
There are two default behaviors that work against this goal:
For (1), in order to prevent the lastest runtime patch from being used, we inject:
into the runtimeconfig.json file
For (2), we want to make sure that only the specified sdk is used. The reason for this is to be able to target the specific runtime version that the SDK ships with. To enforce this, I created an msbuild task that reads the global.json file and compares that version with the actual sdk version used during the build. If they don't match the build fails.
Related issues
Addresses #373