Use Polly instead of EnterpriseLibrary #169 #313
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| @@ -21,19 +22,20 @@ public RetryExceptionPolicyFactory(CosmosDataStoreConfiguration configuration) | |||
| EnsureArg.IsNotNull(configuration, nameof(configuration)); | |||
|
|
|||
| _maxNumberOfRetries = configuration.RetryOptions.MaxNumberOfRetries; | |||
| _minWaitTime = TimeSpan.FromSeconds(Math.Min(RetryStrategy.DefaultMinBackoff.TotalSeconds, configuration.RetryOptions.MaxWaitTimeInSeconds)); | |||
| _minWaitTime = TimeSpan.FromSeconds(configuration.RetryOptions.MinWaitTimeInSeconds); | |||
| _maxWaitTime = TimeSpan.FromSeconds(configuration.RetryOptions.MaxWaitTimeInSeconds); | |||
There was a problem hiding this comment.
Looks like both _minWaitTime and _maxWaitTime are unused now. If so these vars can be removed
| @@ -98,7 +98,7 @@ public sealed class FhirDataStore : IDataStore, IProvideCapability | |||
| _logger.LogDebug($"Upserting {resource.ResourceTypeName}/{resource.ResourceId}, ETag: \"{weakETag?.VersionId}\", AllowCreate: {allowCreate}, KeepHistory: {keepHistory}"); | |||
|
|
|||
| UpsertWithHistoryModel response = await _retryExceptionPolicyFactory.CreateRetryPolicy().ExecuteAsync( | |||
| async () => await _upsertWithHistoryProc.Execute( | |||
| async (ct) => await _upsertWithHistoryProc.Execute( | |||
There was a problem hiding this comment.
Unused param. Either remove like below or look at adding/passing through the CancellationToken in the Execute function.
Suggested change
| async (ct) => await _upsertWithHistoryProc.Execute( | |
| async _ => await _upsertWithHistoryProc.Execute( |
| _maxWaitTime, | ||
| RetryStrategy.DefaultClientBackoff); | ||
| var policy = Policy | ||
| .Handle<Exception>(RetryExceptionPolicy.IsTransient) |
There was a problem hiding this comment.
We could probably take more advantage of Polly here and handle DocumentClientException specifically.
|
Updating and moving to #369 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed out EnterpriseLibrary transient error retry for Polly
Related issues
Addresses [issue #169].
Testing
All the unit tests pass. Per Polly documentation, there is not way to individual unit test Polly.