Removes FhirRepository class #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Microsoft.Health.Fhir.Core/Features/Resources/Get/GetResourceHandler.cs
Outdated
Show resolved
Hide resolved
|
|
||
| namespace Microsoft.Health.Fhir.Core.Features.Resources.Delete | ||
| { | ||
| public class FireEventForDeleteResourceBehavior : |
There was a problem hiding this comment.
Maybe we should remove the event stuff for now since we're not using it. Same goes for the UpsertedEvent
There was a problem hiding this comment.
These should probably replace the AuditFilters...next time then.
src/Microsoft.Health.Fhir.Core/Messages/Delete/DeleteResourceResponse.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Fhir.Core/Messages/Delete/ResourceDeletedEvent.cs
Outdated
Show resolved
Hide resolved
brendankowitz
force-pushed
the
personal/bkowitz/remove-repository
branch
2 times, most recently
from
b716055 to
686728a
Compare
johnstairs
reviewed
Dec 12, 2018
|
|
||
| namespace Microsoft.Health.Fhir.Core.Extensions | ||
| { | ||
| public static class FhirRepositoryExtensions |
There was a problem hiding this comment.
Use these from controller. Maybe include search?
johnstairs
approved these changes
Dec 12, 2018
brendankowitz
force-pushed
the
personal/bkowitz/remove-repository
branch
from
0525eb2 to
3813635
Compare
brendankowitz
force-pushed
the
personal/bkowitz/remove-repository
branch
from
3813635 to
d5b1443
Compare
brendankowitz
force-pushed
the
personal/bkowitz/remove-repository
branch
from
d5b1443 to
6f418f1
Compare
poadhika
pushed a commit
that referenced
this pull request
Jan 2, 2019
Removes the FhirRepository layer and moves the existing logic into the corresponding request handlers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the functionality from FhirRepository into the respective message handlers, #285