Allow multiple search index entries to be generated by one ISearchValue #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstairs
reviewed
Nov 9, 2018
| private bool ExcludeTokenText { get; set; } | ||
| private bool IsCompositeComponent => Index != null; | ||
|
|
||
| private JObject CurrentEntry { get; set; } |
There was a problem hiding this comment.
Do you need the Entry property? Having Entry and CurrentEntry properties is maybe a bit confusing.
There was a problem hiding this comment.
We only need parameter name so I can make that explicitly.
johnstairs
approved these changes
Nov 9, 2018
This was referenced Nov 12, 2018
jackliums
added a commit
that referenced
this pull request
Nov 12, 2018
jackliums
deleted the
personal/jackliu/allow-multiple-entries-to-be-generated
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In SearchIndexEntryJObjectGenerator, allow multiple JObject to be created from a single ISearchValue (which is needed for composite search parameters). Since it can loop through each component, it avoids some allocations.
Migrated the code from #167.