-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supports _type search parameter, search across all resource types, and :missing modifier #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, we are eliminating the welcome page (which would only show if UI is enabled). |
@jackliums, I opted against using ARRAY_CONTAINS for :missing. Instead, I think we should generalize to use it whenever all predicates on a parameter value are equality comparisons. A subsequent PR... |
jackliums
reviewed
Oct 30, 2018
jackliums
reviewed
Oct 30, 2018
src/Microsoft.Health.Fhir.Core.UnitTests/Features/Search/SearchOptionsFactoryTests.cs
Show resolved
Hide resolved
jackliums
reviewed
Oct 30, 2018
src/Microsoft.Health.Fhir.Core/Features/Search/Expressions/Parsers/ExpressionParser.cs
Outdated
Show resolved
Hide resolved
jackliums
reviewed
Oct 30, 2018
jackliums
reviewed
Oct 30, 2018
src/Microsoft.Health.Fhir.Core/Features/Search/Expressions/SearchParameterExpression.cs
Outdated
Show resolved
Hide resolved
jackliums
reviewed
Oct 30, 2018
src/Microsoft.Health.Fhir.Core/Features/Search/SearchIndexer.cs
Outdated
Show resolved
Hide resolved
jackliums
reviewed
Oct 30, 2018
src/Microsoft.Health.Fhir.Core/Features/Search/SearchOptionsFactory.cs
Outdated
Show resolved
Hide resolved
jackliums
reviewed
Oct 30, 2018
src/Microsoft.Health.Fhir.CosmosDb/Features/Search/Queries/ExpressionQueryBuilder.cs
Outdated
Show resolved
Hide resolved
jackliums
reviewed
Oct 30, 2018
src/Microsoft.Health.Fhir.CosmosDb/Features/Search/Queries/ExpressionQueryBuilder.cs
Show resolved
Hide resolved
jackliums
reviewed
Oct 30, 2018
src/Microsoft.Health.Fhir.CosmosDb/Features/Search/Queries/ExpressionQueryBuilder.cs
Outdated
Show resolved
Hide resolved
jackliums
reviewed
Oct 30, 2018
src/Microsoft.Health.Fhir.CosmosDb/Features/Search/Queries/QueryBuilder.cs
Outdated
Show resolved
Hide resolved
jackliums
reviewed
Oct 30, 2018
src/Microsoft.Health.Fhir.CosmosDb/Features/Search/Queries/QueryBuilder.cs
Outdated
Show resolved
Hide resolved
jackliums
reviewed
Oct 30, 2018
src/Microsoft.Health.Fhir.CosmosDb/Features/Search/Queries/QueryBuilder.cs
Outdated
Show resolved
Hide resolved
jackliums
reviewed
Oct 31, 2018
src/Microsoft.Health.Fhir.CosmosDb/Features/Search/Queries/ExpressionQueryBuilder.cs
Outdated
Show resolved
Hide resolved
jackliums
reviewed
Oct 31, 2018
src/Microsoft.Health.Fhir.CosmosDb/Features/Search/Queries/ExpressionQueryBuilder.cs
Show resolved
Hide resolved
jackliums
reviewed
Oct 31, 2018
src/Microsoft.Health.Fhir.Api.UnitTests/Controllers/FhirControllerTests.cs
Show resolved
Hide resolved
jackliums
approved these changes
Nov 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For access control, we need to the resource type to be included in the search expression tree. This also opens up the possibility of supporting the
_type
search parameter and searches across all resource types (/?_lastUpdated=gt2010-10-01
in addition to/Observation?_lastUpdated=gt2010-10-01
).Also makes an adjustment to the search expression trees, to explicitly state which search parameter an expression tree is bound to, by introducing a
SearchParameterExpression
type. Previously, there was just a convention, an implicit contract between the expression parser and the data layer. This meant that(AND (AND a b) (AND c d))
was not the same as(AND a b c d)
, so tree rewriting would not be a safe thing to do.Finally, we implement support for the
:missing
search parameter modifier.Resolves #152
Resolves #153