Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports _type search parameter, search across all resource types, and :missing modifier #154

Merged
merged 12 commits into from
Nov 1, 2018

Conversation

johnstairs
Copy link
Member

For access control, we need to the resource type to be included in the search expression tree. This also opens up the possibility of supporting the _type search parameter and searches across all resource types (/?_lastUpdated=gt2010-10-01 in addition to /Observation?_lastUpdated=gt2010-10-01).

Also makes an adjustment to the search expression trees, to explicitly state which search parameter an expression tree is bound to, by introducing a SearchParameterExpression type. Previously, there was just a convention, an implicit contract between the expression parser and the data layer. This meant that (AND (AND a b) (AND c d)) was not the same as (AND a b c d), so tree rewriting would not be a safe thing to do.

Finally, we implement support for the :missing search parameter modifier.

Resolves #152
Resolves #153

@johnstairs johnstairs requested a review from jackliums October 27, 2018 00:30
@johnstairs
Copy link
Member Author

Also, we are eliminating the welcome page (which would only show if UI is enabled).

@johnstairs
Copy link
Member Author

@jackliums, I opted against using ARRAY_CONTAINS for :missing. Instead, I think we should generalize to use it whenever all predicates on a parameter value are equality comparisons. A subsequent PR...

@cunninghamjc cunninghamjc added Area-Authorization Area related to authorization. Area-Search Area related to search. and removed Area-Authorization Area related to authorization. Area-Search Area related to search. labels Oct 29, 2018
@johnstairs johnstairs merged commit ba711e1 into master Nov 1, 2018
@johnstairs johnstairs deleted the personal/jostairs/type-parameter branch May 11, 2019 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants