Role definitions during deployment #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r and updated deployment documentation
johnstairs
reviewed
Oct 25, 2018
|
Since we are "promoting" this to the public scripts: try {
New-AzureADServiceAppRoleAssignment -ObjectId $ObjectId -PrincipalId $ObjectId -ResourceId $apiApplication.ObjectId -Id $role | Out-Null
}
catch {
Write-Host "Powershell reported failure adding app role assignment for service principal."
}Maybe we could check in the catch block that the assignment went though, and not log anything if it has. |
johnstairs
reviewed
Oct 25, 2018
samples/scripts/PowerShell/FhirServer/Public/New-FhirServerClientApplicationRegistration.ps1
Outdated
Show resolved
Hide resolved
johnstairs
approved these changes
Oct 25, 2018
|
@johnstairs added a check to see if role is in fact assigned when role assignment throws error. |
brandonpollett
approved these changes
Oct 25, 2018
| .PARAMETER FhirServiceName | ||
| Name of the FHIR service instance. | ||
| .PARAMETER FhirServiceAudience | ||
| Full URL of the FHIR service. | ||
| .PARAMETER WebAppSuffix | ||
| Will be appended to FHIR service name to form the FhirServiceAudience if one is not supplied, | ||
| e.g., azurewebsites.net or azurewebsites.us (for US Government cloud) | ||
| .PARAMETER AppRole |
| @@ -16,6 +16,8 @@ function New-FhirServerClientApplicationRegistration { | |||
| Identifier URI for the client AAD Application registration | |||
| .PARAMETER PublicClient | |||
| Switch to indicate if the client application should be a public client (desktop/mobile applications) | |||
| .PARAMETER Roles | |||
There was a problem hiding this comment.
This isn't a parameter on this script.
| .PARAMETER ApiAppId | ||
| The objectId of the API application that has roles that need to be assigned | ||
| .PARAMETER AppRoles | ||
| The collection of roles from the testauthenvironment.json for the client application |
There was a problem hiding this comment.
No longer just from testauthenvironment.json
| .EXAMPLE | ||
| Set-FhirServerUserAppRoleAssignments -UserPrincipalName <User Principal Name> -ApiAppId <Resource Api Id> -AppRoles admin,nurse | ||
| .PARAMETER Upn | ||
| The AppId of the of the client application |
There was a problem hiding this comment.
Mismatch on the description and parameter
| .PARAMETER Upn | ||
| The AppId of the of the client application | ||
| .PARAMETER ApiAppId | ||
| The objectId of the API application that has roles that need to be assigned |
There was a problem hiding this comment.
Mismatch on the description and parameter
| Set AppRoles for a given user. Requires Azure AD admin privileges. | ||
| .EXAMPLE | ||
| Set-FhirServerUserAppRoleAssignments -UserPrincipalName <User Principal Name> -ApiAppId <Resource Api Id> -AppRoles admin,nurse | ||
| .PARAMETER Upn |
There was a problem hiding this comment.
Parameter name doesn't match between documentation and actual parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #135
Closes #128