Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace live server by five server #4529

Merged
merged 2 commits into from
Apr 5, 2021
Merged

chore: replace live server by five server #4529

merged 2 commits into from
Apr 5, 2021

Conversation

yandeu
Copy link
Contributor

@yandeu yandeu commented Apr 1, 2021

Description

Replaced Live Server by Five Server in the site-rebrand-tutorial.

Motivation & context

Five Server is a fork of Live Server with updated dependencies and fixed vulnerabilities.
In addition, it provides features like instant update, highlight and remote logging.

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Adding or modifying component(s) in @microsoft/fast-components checklist

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Copy link
Contributor

@EisenbergEffect EisenbergEffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me!

@codeclimate
Copy link

codeclimate bot commented Apr 5, 2021

Code Climate has analyzed commit 2f59124 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 85.2% (0.0% change).

View more on Code Climate.

@EisenbergEffect EisenbergEffect merged commit a4fd105 into microsoft:master Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants