Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): add design systems section to documentation #3747

Merged
merged 30 commits into from
Aug 26, 2020

Conversation

nicholasrice
Copy link
Contributor

@nicholasrice nicholasrice commented Aug 19, 2020

Description

Documentation for FAST's Design System implementation and architecture is fragmented and hard to follow. This PR adds a section to the documentation to specifically address questions surrounding:

  1. What the Design System is
  2. How the Design System is used
  3. How the Design System infrastructure functionally works
  4. How to leverage the FAST Frame Design System
  5. How to extend the existing FAST Frame Design System
  6. How to create a new Design System

I wasn't sure what to do with the remaining content in the "Design" section under "Using FAST Components" - if any one has any ideas there please chime in.

closes #3738

Motivation & context

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Adding or modifying component(s) in @microsoft/fast-components checklist

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@nicholasrice nicholasrice added chore Maintenance or non-code work docs:article Additions, improvements, or fixes to site articles area:site Pertains to work on the web site. labels Aug 19, 2020
@nicholasrice nicholasrice force-pushed the users/nirice/design-system-documentation branch from 0fab896 to 8fcb4f7 Compare August 21, 2020 22:03
@nicholasrice nicholasrice marked this pull request as ready for review August 24, 2020 23:47
sidebar_label: Overview
custom_edit_url: https://github.com/microsoft/fast/edit/master/sites/website/src/docs/design-systems/overview.md
---
A *Design System* is somewhat of an amorphous term but can generally be thought of as a collection of resources for interactive media that promotes brand alignment. While that definition is intentionally broad, in UI development, Design Systems generally manifest as component libraries surrounded by usage guidance and design principles.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about... "A Design System is a collection of resources for interactive media that promotes brand alignment. While that definition is intentionally broad, in UI development, Design Systems manifest as component libraries surrounded by usage guidance and design principles."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The point is that there is a very broad definition in the industry about what a design system actually is - I'm not sure we want to declare the industry term here, just set the stage for how the term is used in FAST today

custom_edit_url: https://github.com/microsoft/fast/edit/master/sites/website/src/docs/design-systems/using-the-design-system.md
---

This section goes into further detail on how the Design System can be used. It will use [FAST Frame](/docs/design-systems/fast-frame) Design System in the examples but none are *specific* to [FAST Frame](/docs/design-systems/fast-frame); use these features with your own Design System if you're not using [FAST Frame](/docs/design-systems/fast-frame).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like the first sentence is given already in the title. Would suggest removing

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe could begin with "Using FAST Frame in the Design system" or some variation perhaps

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this to be sure folks didn't conflate this with documentation that is specific to FAST Frame because it is general purpose documentation. I think removing this would cause confusion between using the FAST Frame Design System and using any Design System

sites/website/src/docs/design-systems/overview.md Outdated Show resolved Hide resolved
sites/website/src/docs/design-systems/overview.md Outdated Show resolved Hide resolved
sites/website/src/docs/design-systems/overview.md Outdated Show resolved Hide resolved
sites/website/src/docs/design-systems/overview.md Outdated Show resolved Hide resolved
sites/website/src/docs/design-systems/fast-frame.md Outdated Show resolved Hide resolved
sites/website/src/docs/design-systems/fast-frame.md Outdated Show resolved Hide resolved
@EisenbergEffect EisenbergEffect added the community:noteworthy An issue or PR of particular interest to the community or planned for an announcement. label Aug 26, 2020
@EisenbergEffect EisenbergEffect self-requested a review August 26, 2020 22:17
@awentzel awentzel merged commit f313594 into master Aug 26, 2020
@awentzel awentzel deleted the users/nirice/design-system-documentation branch August 26, 2020 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:site Pertains to work on the web site. chore Maintenance or non-code work community:noteworthy An issue or PR of particular interest to the community or planned for an announcement. docs:article Additions, improvements, or fixes to site articles
Projects
None yet
4 participants