Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: slider vertical navigation and value setting bugs #3176

Merged
merged 6 commits into from
May 22, 2020

Conversation

marjonlynch
Copy link
Contributor

Description

  • fixed issue with arrow keys navigating the whole page as well as the silder
  • fixed bug where initial value of slider was not setting the thumb position correctly
  • fixed bug in vertical orientation where movement via mouse was not correct
  • Added headers to all the examples in slider and radio-group
  • Fixed color for radio-group slotted labels in fast-components

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@marjonlynch marjonlynch merged commit f46d87d into master May 22, 2020
@marjonlynch marjonlynch deleted the users/marjon/slider-math-update branch May 22, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants