Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure null values are removed from tabs #2805

Merged
merged 4 commits into from
Mar 18, 2020
Merged

fix: ensure null values are removed from tabs #2805

merged 4 commits into from
Mar 18, 2020

Conversation

eljefe223
Copy link
Contributor

@eljefe223 eljefe223 commented Mar 18, 2020 •
edited
Loading

Description

Preact does not filter out null results in children.map added a function to filter for truthyness.

This PR is form 2018 and never got merged in:
preactjs/preact-compat#461

Motivation & context

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@eljefe223 eljefe223 self-assigned this Mar 18, 2020
@eljefe223 eljefe223 changed the title fix: preact is not rendering tab panels fix: ensure null values are removed from tabs Mar 18, 2020
@eljefe223 eljefe223 force-pushed the users/jes/preact-tabs branch from 4cea895 to d721c05 Compare March 18, 2020 20:39
@eljefe223 eljefe223 merged commit 5c032d0 into master Mar 18, 2020
@eljefe223 eljefe223 deleted the users/jes/preact-tabs branch March 18, 2020 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholasrice nicholasrice nicholasrice approved these changes

@chrisdholt chrisdholt chrisdholt approved these changes

@janechu janechu Awaiting requested review from janechu

Assignees

@eljefe223 eljefe223

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eljefe223 @nicholasrice @chrisdholt