Merge branch 'master' into users/janechu/add-architecture-doc

microsoft · Jan 15, 2025 · ce84025 · ce84025
2 parents 903b060 + d4be0d2
commit ce84025
Show file tree

Hide file tree

Showing 21 changed files with 143 additions and 44 deletions.
diff --git a/.github/workflows/cd-release-npm.yml b/.github/workflows/cd-release-npm.yml
@@ -16,7 +16,7 @@ jobs:
     strategy:
       matrix:
         node: [20.x]
-    if: contains('chrisdholt,janechu,nicholasrice,awentzel,eisenbergeffect', github.actor)
+    if: contains('chrisdholt,janechu', github.actor)
 
     steps:
     - uses: actions/checkout@v4
@@ -48,15 +48,25 @@ jobs:
       run: npm run checkchange
 
     - name: Testing Prettier format
-      run: npm run prettier:diff
+      run: npm run format:check
+
+    - name: Build workspaces
+      run: npm run build
+
+    - name: Install playwright dependencies and browsers
+      run: |
+        npx playwright install
 
     - name: Testing unit tests
-      run: npm run test --stream
+      run: npm run test
+
+    - name: Testing final validation
+      run: npm run test:validation
 
     - name: Publish NPM packages
       env:
         NPM_SECRET_TOKEN: ${{ secrets.NPM_TOKEN }}
-      run: npm run publish-ci -n $NPM_SECRET_TOKEN
+      run: npm run publish-ci -- --token "$NPM_SECRET_TOKEN"
 
   notify:
     runs-on: ubuntu-latest

diff --git a/README.md b/README.md
@@ -7,14 +7,9 @@
 [![TypeScript](https://img.shields.io/badge/%3C%2F%3E-TypeScript-%230074c1.svg)](https://www.typescriptlang.org/)
 [![code style: prettier](https://img.shields.io/badge/code_style-prettier-f8bc45.svg)](https://github.com/prettier/prettier)
 
-[![Maintainability](https://api.codeclimate.com/v1/badges/8a74621e634a6e9b9561/maintainability)](https://codeclimate.com/github/Microsoft/fast/maintainability)
-[![Test Coverage](https://api.codeclimate.com/v1/badges/8a74621e634a6e9b9561/test_coverage)](https://codeclimate.com/github/Microsoft/fast/test_coverage)
 [![Validate PRs](https://github.com/microsoft/fast/actions/workflows/ci-validate-pr.yml/badge.svg)](https://github.com/microsoft/fast/actions/workflows/ci-validate-pr.yml)
 [![Validate Platforms/Browsers](https://github.com/microsoft/fast/actions/workflows/ci-validate-platforms.yml/badge.svg)](https://github.com/microsoft/fast/actions/workflows/ci-validate-platforms.yml)
 
-[![Deploy Documentation](https://github.com/microsoft/fast/actions/workflows/cd-deploy-www-production.yml/badge.svg)](https://github.com/microsoft/fast/actions/workflows/cd-deploy-www-production.yml)
-[![Deploy CDN](https://github.com/microsoft/fast/actions/workflows/cd-deploy-cdn.yml/badge.svg)](https://github.com/microsoft/fast/actions/workflows/cd-deploy-cdn.yml)
-
 [![Discord](https://img.shields.io/badge/chat%20on-discord-7289da.svg)](https://discord.gg/FcSNfg4)
 [![Twitter](https://img.shields.io/twitter/follow/fast_ui.svg?style=social&label=Follow)](https://twitter.com/intent/follow?screen_name=fast_ui)
 
@@ -58,10 +53,14 @@ We hope you're excited by the possibilities that FAST presents. But, you may be
 * "I want to build my own components."
   * [Jump to the fast-element docs.](https://fast.design/docs/fast-element/getting-started)
 * "I need to integrate FAST with another framework or build system."
-  * [Jump to the integration docs.](https://fast.design/docs/integrations/introduction)
+  * [Jump to the integration docs.](https://fast.design/docs/integrations)
 * "I want to look at a quick reference."
   * [Jump to the Cheat Sheet](https://fast.design/docs/resources/cheat-sheet)
 
+## Roadmap
+
+Major features for the FAST project can be found in the [roadmap](https://github.com/orgs/microsoft/projects/240/views/1).
+
 ## Joining the Community
 
 Looking to get answers to questions or engage with us in realtime? Our community is most active [on Discord](https://discord.gg/FcSNfg4). Submit requests and issues on [GitHub](https://github.com/Microsoft/fast/issues/new/choose), or join us by contributing on [some good first issues via GitHub](https://github.com/Microsoft/fast/labels/community:good-first-issue).

diff --git a/beachball.config.js b/beachball.config.js
@@ -11,4 +11,5 @@ module.exports = {
         // This one is especially important (otherwise dependabot would be blocked by change file requirements)
         "package-lock.json",
     ],
+    bumpDeps: false
 };
diff --git a/change/@microsoft-fast-ssr-45005c89-fa17-44c9-b1ec-ef76c42e269e.json b/change/@microsoft-fast-ssr-45005c89-fa17-44c9-b1ec-ef76c42e269e.json
diff --git a/examples/ssr/package.json b/examples/ssr/package.json
@@ -23,7 +23,7 @@
     "directory": "examples/ssr"
   },
   "dependencies": {
-    "@microsoft/fast-element": "^2.0.0",
+    "@microsoft/fast-element": "^2.0.1",
     "@microsoft/fast-foundation": "^3.0.0-alpha.33",
     "@microsoft/fast-ssr": "^1.0.0-beta.35",
     "express": "^4.19.2",

diff --git a/examples/todo-app/package.json b/examples/todo-app/package.json
@@ -22,7 +22,7 @@
     "directory": "examples/todo-app"
   },
   "dependencies": {
-    "@microsoft/fast-element": "^2.0.0",
+    "@microsoft/fast-element": "^2.0.1",
     "@microsoft/fast-foundation": "^3.0.0-alpha.33",
     "tslib": "^2.6.3"
   },

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -31,7 +31,7 @@
   "scripts": {
     "bump": "beachball bump",
     "build": "npm run build --workspaces --if-present",
-    "change": "beachball change",
+    "change": "beachball change --dependent-change-type none",
     "checkchange": "beachball check  --scope \"!sites/*\" --changehint \"Run 'npm run change' to generate a change file\"",
     "check": "beachball check ",
     "build:gh-pages": "npm run build -w fast-site",

diff --git a/packages/web-components/fast-element/CHANGELOG.json b/packages/web-components/fast-element/CHANGELOG.json
@@ -1,6 +1,27 @@
 {
   "name": "@microsoft/fast-element",
   "entries": [
+    {
+      "date": "Wed, 11 Dec 2024 19:53:31 GMT",
+      "version": "2.0.1",
+      "tag": "@microsoft/fast-element_v2.0.1",
+      "comments": {
+        "patch": [
+          {
+            "author": "[email protected]",
+            "package": "@microsoft/fast-element",
+            "commit": "33111eeff26ab4ae2bbe1c90145170ed175d2217",
+            "comment": "Patch bumping to apply latest tag to the package"
+          },
+          {
+            "author": "[email protected]",
+            "package": "@microsoft/fast-element",
+            "commit": "51a79eb3294897fb1e71b5dcdcce0bea62521e80",
+            "comment": "fast-element: Simplify conditional checks in element-controller"
+          }
+        ]
+      }
+    },
     {
       "date": "Mon, 19 Aug 2024 22:04:19 GMT",
       "version": "2.0.0",

diff --git a/packages/web-components/fast-element/CHANGELOG.md b/packages/web-components/fast-element/CHANGELOG.md
@@ -1,9 +1,18 @@
 # Change Log - @microsoft/fast-element
 
-This log was last generated on Mon, 19 Aug 2024 22:04:19 GMT and should not be manually modified.
+This log was last generated on Wed, 11 Dec 2024 19:53:31 GMT and should not be manually modified.
 
 <!-- Start content -->
 
+## 2.0.1
+
+Wed, 11 Dec 2024 19:53:31 GMT
+
+### Patches
+
+- Patch bumping to apply latest tag to the package ([email protected])
+- fast-element: Simplify conditional checks in element-controller ([email protected])
+
 ## 2.0.0
 
 Mon, 19 Aug 2024 22:04:19 GMT

diff --git a/packages/web-components/fast-element/package.json b/packages/web-components/fast-element/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@microsoft/fast-element",
   "description": "A library for constructing Web Components",
-  "version": "2.0.0",
+  "version": "2.0.1",
   "author": {
     "name": "Microsoft",
     "url": "https://discord.gg/FcSNfg4"

diff --git a/packages/web-components/fast-element/src/components/attributes.ts b/packages/web-components/fast-element/src/components/attributes.ts
@@ -80,13 +80,13 @@ export const booleanConverter: ValueConverter = {
     },
 
     fromView(value: any): any {
-        return value === null ||
+        return !(
+            value === null ||
             value === void 0 ||
             value === "false" ||
             value === false ||
             value === 0
-            ? false
-            : true;
+        );
     },
 };
 
@@ -202,7 +202,7 @@ export class AttributeDefinition implements Accessor {
     /**
      * Sets the value of the attribute/property on the source element.
      * @param source - The source element to access.
-     * @param value - The value to set the attribute/property to.
+     * @param newValue - The value to set the attribute/property to.
      */
     public setValue(source: HTMLElement, newValue: any): void {
         const oldValue = source[this.fieldName];

diff --git a/packages/web-components/fast-router/CHANGELOG.json b/packages/web-components/fast-router/CHANGELOG.json
@@ -1,6 +1,27 @@
 {
   "name": "@microsoft/fast-router",
   "entries": [
+    {
+      "date": "Wed, 11 Dec 2024 19:53:31 GMT",
+      "version": "1.0.0-alpha.29",
+      "tag": "@microsoft/fast-router_v1.0.0-alpha.29",
+      "comments": {
+        "prerelease": [
+          {
+            "author": "[email protected]",
+            "package": "@microsoft/fast-router",
+            "commit": "1238af4df3abec01799cb05c5657f8d245cf3f25",
+            "comment": "Change the router to use peerDependency for fast-element"
+          },
+          {
+            "author": "beachball",
+            "package": "@microsoft/fast-router",
+            "comment": "Bump @microsoft/fast-element to v2.0.1",
+            "commit": "not available"
+          }
+        ]
+      }
+    },
     {
       "date": "Mon, 19 Aug 2024 22:04:19 GMT",
       "version": "1.0.0-alpha.28",

diff --git a/packages/web-components/fast-router/CHANGELOG.md b/packages/web-components/fast-router/CHANGELOG.md
@@ -1,9 +1,18 @@
 # Change Log - @microsoft/fast-router
 
-This log was last generated on Mon, 19 Aug 2024 22:04:19 GMT and should not be manually modified.
+This log was last generated on Wed, 11 Dec 2024 19:53:31 GMT and should not be manually modified.
 
 <!-- Start content -->
 
+## 1.0.0-alpha.29
+
+Wed, 11 Dec 2024 19:53:31 GMT
+
+### Changes
+
+- Change the router to use peerDependency for fast-element ([email protected])
+- Bump @microsoft/fast-element to v2.0.1
+
 ## 1.0.0-alpha.28
 
 Mon, 19 Aug 2024 22:04:19 GMT

diff --git a/packages/web-components/fast-router/package.json b/packages/web-components/fast-router/package.json
@@ -2,7 +2,7 @@
   "name": "@microsoft/fast-router",
   "description": "A web-components-based router.",
   "sideEffects": false,
-  "version": "1.0.0-alpha.28",
+  "version": "1.0.0-alpha.29",
   "author": {
     "name": "Microsoft",
     "url": "https://discord.gg/FcSNfg4"
@@ -48,6 +48,7 @@
   "devDependencies": {
     "@jsdevtools/coverage-istanbul-loader": "^3.0.5",
     "@microsoft/api-extractor": "^7.47.0",
+    "@microsoft/fast-element": "^2.0.1",
     "@types/chai": "^4.2.11",
     "@types/karma": "^6.3.3",
     "@types/mocha": "^7.0.2",
@@ -80,8 +81,8 @@
     "webpack": "^5.92.1",
     "webpack-cli": "^5.1.4"
   },
-  "dependencies": {
-    "@microsoft/fast-element": "^2.0.0"
+  "peerDependencies": {
+    "@microsoft/fast-element": "^2.0.1"
   },
   "beachball": {
     "disallowedChangeTypes": [

diff --git a/packages/web-components/fast-ssr/CHANGELOG.json b/packages/web-components/fast-ssr/CHANGELOG.json
@@ -1,6 +1,33 @@
 {
   "name": "@microsoft/fast-ssr",
   "entries": [
+    {
+      "date": "Wed, 11 Dec 2024 19:53:32 GMT",
+      "version": "1.0.0-beta.35",
+      "tag": "@microsoft/fast-ssr_v1.0.0-beta.35",
+      "comments": {
+        "none": [
+          {
+            "author": "[email protected]",
+            "package": "@microsoft/fast-ssr",
+            "commit": "26c5078fff7b7d4990d4143913a71def113f2874",
+            "comment": "Update playwright image and dependency to latest"
+          },
+          {
+            "author": "[email protected]",
+            "package": "@microsoft/fast-ssr",
+            "commit": "a3c98e184642949bbb5b4318b5e233b49ad0b902",
+            "comment": "Attempt to address flaky test by increasing timeout"
+          },
+          {
+            "author": "beachball",
+            "package": "@microsoft/fast-ssr",
+            "comment": "Bump @microsoft/fast-element to v2.0.1",
+            "commit": "not available"
+          }
+        ]
+      }
+    },
     {
       "date": "Mon, 19 Aug 2024 22:04:19 GMT",
       "version": "1.0.0-beta.35",

diff --git a/packages/web-components/fast-ssr/package.json b/packages/web-components/fast-ssr/package.json
@@ -56,11 +56,11 @@
     "tslib": "^2.6.3"
   },
   "peerDependencies": {
-    "@microsoft/fast-element": "^2.0.0"
+    "@microsoft/fast-element": "^2.0.1"
   },
   "devDependencies": {
     "@microsoft/api-extractor": "^7.47.0",
-    "@microsoft/fast-element": "^2.0.0",
+    "@microsoft/fast-element": "^2.0.1",
     "@microsoft/fast-foundation": "^3.0.0-alpha.33",
     "@playwright/test": "^1.49.0",
     "@types/express": "^4.17.21",