This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
Add support for Kustomize to fab generate. Implementation of #239. (Recovered) #311
Open
andrewDoing
wants to merge
13
commits into
microsoft:develop
Choose a base branch
from
andrewDoing:develop
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edaena
approved these changes
Sep 1, 2020
@andrewDoing we need to add documentation for this. cc @evanlouie |
andrebriggs
suggested changes
Sep 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mentioned above
andrebriggs
reviewed
Sep 22, 2020
andrebriggs
suggested changes
Sep 22, 2020
evanlouie
approved these changes
Nov 2, 2020
Kustomize looks like a delightful addition to fabrikate and could kustomize would be a welcome addition for a few parties (from what I can see on issues). I'm only beginning to look at fabrikate/bedrock but I feel like I'd need kustomize support pretty early on to get the party started. Appreciative either way! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I'm remaking this PR because while cleaning my branches I removed the changes from the branch used in the previous PR. I had to rewrite the documentation of the functions, but otherwise is the same as before.
This pull request adds a -k or --kustomize option to fab generate. When this option is passed, a kustomization.yaml will be generated for each environment with the Kubernetes YAML files added as resources. This allows executing kubectl apply -k on directories with the generated files.
This PR implements #239, and was inspired by #240
Refactored kustomize code into its own file
Added tests
Updated generate.go, adding kustomize to the command line options
Updated generate_test.go, adding the false parameter for kustomize (fixes the tests)
Added "kustomize" go the .gitignore so the tests can generate kustomize.yaml files without adding them to the working tree.