Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eslint-plugin-react to be compatible with eslint v8 #50

Merged
merged 4 commits into from
Aug 1, 2023

Conversation

syphe
Copy link
Contributor

@syphe syphe commented Jul 25, 2023

As far as I can tell this change is backwards compatible, as eslint-plugin-react has a wide list of allowed eslint versions

@matwilko
Copy link

Quick note that I also added a peerDependencies for eslint in #51 - it's based on the current version of eslint-plugin-react, but I'd suggest also adding a compatible peerDependencies in this PR with the updated requirements - then if this gets merged, I can just close that PR as obsolete 😄

package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@Vflouirac Vflouirac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Vflouirac Vflouirac merged commit 65e302d into microsoft:main Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants