Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Fix Vsixs at Runtime #420

Merged
merged 10 commits into from
May 4, 2017
Merged

Fix Vsixs at Runtime #420

merged 10 commits into from
May 4, 2017

Conversation

conniey
Copy link
Member

@conniey conniey commented May 3, 2017

  • At runtime, there were FileNotFoundExceptions because of app.configs I had updated in Migrate solution to VS2017 #411. In this PR, I removed them because they are not necessary. Now the vsix runs on VS2015 and VS2017.
  • Fixed a NullReferenceException when disposing of OptionsPage

@conniey conniey force-pushed the fixResolvingVsix branch from 23652bf to 261cb2c Compare May 3, 2017 22:48
@conniey conniey requested a review from twsouthwick May 3, 2017 23:44
@conniey
Copy link
Member Author

conniey commented May 3, 2017

@twsouthwick can you take a quick look at this PR? It was mostly because I would experience runtime changes in VS2015... so I had to downgrade to use 14.0 packages. And I kept running into FileNotFound exceptions because vsix don't use assembly redirects since it is run inside devenv.exe, so it doesn't use app.config. As a result, I had to write AssemblyRedirectResolver.cs

@conniey conniey merged commit c8a82dd into microsoft:master May 4, 2017
@conniey conniey deleted the fixResolvingVsix branch May 4, 2017 18:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@twsouthwick twsouthwick Awaiting requested review from twsouthwick

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@conniey @msftclas