-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge branch develop into main [2023_09_07] #175
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
shishirb-MSFT
commented
Sep 7, 2023
- Support for Ubuntu Core snaps.
- Support Ubuntu 22.04 and Debian 11.
- Agent: Replace boost::filesystem usage with std::filesystem.
- SDK (Windows): Preview additional methods for partial downloads, streaming downloads, and download properties.
- bootstrap script determines OS and version on its own.
- Fix issue of non-existent /include path during bootstrap and/or build.
… snap (#159) Co-authored-by: Shishir Bhat <[email protected]>
* Agent: Use SNAP_DATA environment variable to ensure agent is writing to directories within the snap filesystem. Without this, the agent was writing to the host filesystem (in devmode). * SDK: Corresponding change required to use SNAP_DATA so that the plugs are used. * Update slot name for the downloads to be unique to DU agent. * Add documentation about snap commands and general info.
* Update ubuntu-snap.md
* Agent binary size is much lower than the limit we were checking against. The limit was probably not updated after the earlier size reductions. * SDK size is lower but only by a small margin. Updated that one too. * Also update the script to fail if size has reduced too much in order to catch this early next time.
* Always wanted to move to the C++17 filesystem implementation. What prompted the change now: The FindBoost issue on Ubuntu 20.04 involving symlinking /lib to /usr/lib but /include being non-existent. * This change removes public dependency on Boost libs entirely, leaving only the tests using boost.program_options. So, our cmake config file will no longer have to deal with the paths for boost. * GCC 8, which is the default at least on Ubuntu 18.04, requires use of std::experimental::filesystem. Code has been changed appropriately to support building with both flavors of filesystem.
* A prior PR (#145) fixed the issue when building DO itself. However, consumers of DO still face the issue because DO's cmake config file was not updated. This is now fixed. * DO's own CMakeLists.txt checks for /lib being a symlink before updating CMAKE_PREFIX_PATH (update to fix in #145). * Also enable exec permission for the sdk cleanup install script.
* Add pipeline suport ubuntu 22.04 * Add Dockerfiles to build ubuntu 22.04 images * fix gtest release * fix gsl include for ubuntu 22.04 * update pip install for ubuntu 22.04 * install file utility dep for CPackDeb
* add parallel flag into build options * add RPi recognizition in the build
* Add pipeline config and Dockerfiles for Debian11 * test new ACR service connection * add gtest support to debian11
* There was a change to test files hosting location recently.
Jerry-GeGarcia
previously approved these changes
Sep 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.