Add Datacleanup job to fix HasFrameData value #3097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsugarman
requested changes
Oct 11, 2023
...icrosoft.Health.Dicom.SqlServer/Features/Schema/Sql/Sprocs/GetInstanceBatchesByTimeStamp.sql
Show resolved
Hide resolved
src/Microsoft.Health.Dicom.SqlServer/Features/Schema/Sql/Sprocs/UpdateFrameMetadata.sql
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Dicom.SqlServer/Features/Schema/Sql/Sprocs/UpdateFrameMetadata.sql
Outdated
Show resolved
Hide resolved
...icrosoft.Health.Dicom.SqlServer/Features/Schema/Sql/Sprocs/GetInstanceBatchesByTimeStamp.sql
Show resolved
Hide resolved
src/Microsoft.Health.Dicom.Functions/DataCleanup/DataCleanupDurableFunction.Orchestration.cs
Show resolved
Hide resolved
src/Microsoft.Health.Dicom.Functions/DataCleanup/DataCleanupDurableFunction.Orchestration.cs
Show resolved
Hide resolved
src/Microsoft.Health.Dicom.Core/Features/Common/IMetadataStore.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Dicom.Core/Configs/InstanceDataCleanupConfiguration.cs
Outdated
Show resolved
Hide resolved
wsugarman
previously approved these changes
Oct 13, 2023
src/Microsoft.Health.Dicom.Blob/Features/Storage/BlobMetadataStore.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Dicom.Core/Features/Retrieve/IInstanceStore.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Dicom.SqlServer/Features/Store/SqlIndexDataStoreV47.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Dicom.SqlServer/Features/Store/SqlIndexDataStoreV47.cs
Outdated
Show resolved
Hide resolved
wsugarman
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds Datacleanup background service which creates a new operation to pull all instances between a time range and updates the hasFrameData boolean if the instance has frame range blob.
Related issues
Addresses [AB#109194].
Testing
Added unit tests for new durable function