min validator bug fix follow up #3065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcarthic
reviewed
Sep 27, 2023
src/Microsoft.Health.Dicom.Core/Features/Validation/LongStringValidation.cs
Outdated
Show resolved
Hide resolved
wsugarman
reviewed
Sep 28, 2023
src/Microsoft.Health.Dicom.Core/Features/Store/StoreDatasetValidator.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Dicom.Core/Features/Store/StoreDatasetValidator.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Dicom.Core/Features/Store/StoreDatasetValidator.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Dicom.Core/Features/Store/StoreDatasetValidator.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Dicom.Core/Features/Validation/DateValidation.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Dicom.Core/Features/Validation/ElementMinimumValidator.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Dicom.Core/Features/Validation/ElementMinimumValidator.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Dicom.Core/Features/Validation/ElementMinimumValidator.cs
Outdated
Show resolved
Hide resolved
bcarthic
reviewed
Sep 28, 2023
Co-authored-by: Will Sugarman <[email protected]>
…ub.com/microsoft/dicom-server into users/esmadau/vs-minvalidator-followup
wsugarman
reviewed
Sep 30, 2023
src/Microsoft.Health.Dicom.Core/Features/Store/StoreDatasetValidator.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Dicom.Core/Features/Validation/DateValidation.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Dicom.Core/Features/Validation/ElementMinimumValidator.cs
Outdated
Show resolved
Hide resolved
wsugarman
reviewed
Oct 6, 2023
src/Microsoft.Health.Dicom.Core/Features/Validation/StringElementValidation.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Dicom.Core/Features/Validation/StringElementValidation.cs
Outdated
Show resolved
Hide resolved
…t for when value is null and we still want to Trim null padding
…we've trimmed null padding if null padding allowed
esmadau
commented
Oct 6, 2023
src/Microsoft.Health.Dicom.Core/Features/Validation/StringElementValidation.cs
Show resolved
Hide resolved
esmadau
commented
Oct 6, 2023
src/Microsoft.Health.Dicom.Core/Features/Validation/StringElementValidation.cs
Outdated
Show resolved
Hide resolved
wsugarman
reviewed
Oct 6, 2023
src/Microsoft.Health.Dicom.Core/Features/Validation/StringElementValidation.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Dicom.Core/Features/Validation/StringElementValidation.cs
Show resolved
Hide resolved
src/Microsoft.Health.Dicom.Core/Features/Validation/StringElementValidation.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Dicom.Core/Features/Validation/StringElementValidation.cs
Outdated
Show resolved
Hide resolved
wsugarman
previously approved these changes
Oct 6, 2023
…again at Validate since others use it for uid
wsugarman
reviewed
Oct 6, 2023
src/Microsoft.Health.Dicom.Core/Features/Validation/LongStringValidation.cs
Outdated
Show resolved
Hide resolved
wsugarman
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
a follow up PR to handle some of the nits from this PR:
#3056
Related issues
Addresses [AB#109857].
Testing
Used existing tests