Add HttpRequestException expected exception handling #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkbennett
requested review from
guimafelipe,
krschau,
EricJohnson327 and
lauren-ciha
krschau
approved these changes
Sep 6, 2024
lauren-ciha
approved these changes
Sep 10, 2024
EricJohnson327
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Adds exception handling to not spam detailed error stack when we have an HttpRequest exception. This keeps the log clean and avoids giving us false alarm exception spam when unrelated network issues happen, such as DNS resolution problems or simply no internet connection.
References and relevant issues
Observed such false alarm spam in: microsoft/devhome#3778
Detailed description of the pull request / Additional comments
Validation steps performed
PR checklist