Review requested widget now is customizable #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krschau
reviewed
Aug 28, 2024
src/GitHubExtension/Widgets/Templates/GitHubReviewConfigurationTemplate.json
Outdated
Show resolved
Hide resolved
lauren-ciha
approved these changes
Aug 28, 2024
krschau
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
This PR makes the "Review Requested" widget customizable.
References and relevant issues
Detailed description of the pull request / Additional comments
This PR changes the code of the Review Request widget to make it similar to the other User widgets. The only difference is that for this widget, the
ShowCategoryproperty is always set toPullRequests.For that, one of the simplest ways is to have a ghost input in the configuration template that sets this variable always, and then no further changes are needed on the code.
Other options would be to inject it in the Json string received by the widget, or rewrite the action handler in this widget giving up of the inheritance capabilities.
For this PR, the first option was chosen.
Validation steps performed
PR checklist