Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing bug where title was not saved when Save button is clicked #391

Merged
merged 1 commit into from
May 15, 2024

Conversation

guimafelipe
Copy link
Contributor

Summary of the pull request

This PR fixes a bug where if the user changes the title of the widget and clics "Save" button, the configuration is not saved.
Now, whenever the "Save" action is invoked, we save the data as the ConfigurationData of the widget.

References and relevant issues

Detailed description of the pull request / Additional comments

Validation steps performed

PR checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated

@krschau krschau added this to the DHGE v0.14 milestone May 13, 2024
@EricJohnson327 EricJohnson327 merged commit 7821908 into main May 15, 2024
2 of 4 checks passed
@EricJohnson327 EricJohnson327 deleted the user/felipeda/fixtitlesavebug branch May 15, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants