Upgrade Octokit to v10.0.0 #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkbennett
approved these changes
Feb 26, 2024
EricJohnson327
approved these changes
Feb 26, 2024
EricJohnson327
pushed a commit
that referenced
this pull request
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
We're seeing lots of exceptions in the data manager due to an issue in Octokit.
"the core issue is that Octokit uses
intforId, where the maximum is 2,147,483,647, and the GitHub issue ID has just surpassed that number, causing deserialization to fail." this PR should have fixed it: Change "IssueId" tolongby Leh2 · Pull Request #2890 · octokit/octokit.net · GitHub and it's included in the v10.0.0 release.Validation steps performed
PR checklist