Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Releases Widget #344

Merged
merged 3 commits into from
Mar 4, 2024
Merged

Add Releases Widget #344

merged 3 commits into from
Mar 4, 2024

Conversation

davidegiacometti
Copy link
Contributor

@davidegiacometti davidegiacometti commented Feb 10, 2024

Summary of the pull request

Add a new widget that displays the releases of a repository.

References and relevant issues

#157

Detailed description of the pull request / Additional comments

Displayed info:

  • Name
  • Tag (redundant?)
  • Published time + Latest / Pre-release

Available info:

  • Author

Releases Widget

Validation steps performed

  • Verified that all strings are localized
  • Tested with a repository without releases
  • Database checks:
    • Verified Release table
    • Verified that TimeLastObserved get updated for repositories that have an active widget
    • Verified that not observed releases are deleted for active widgets
    • Verified that releases get pruned for inactive widgets

PR checklist

@dkbennett
Copy link
Member

Need @cinnamon-msft to weigh in here for a new Widget. This is overall a good integration with the datastore that follows existing paradigms (except where otherwise noted), so apart from my changes above I have no objections to this widget, but design needs to weigh in on whether this fits into the extension.

@cinnamon-msft
Copy link
Contributor

Need @cinnamon-msft to weigh in here for a new Widget. This is overall a good integration with the datastore that follows existing paradigms (except where otherwise noted), so apart from my changes above I have no objections to this widget, but design needs to weigh in on whether this fits into the extension.

This looks awesome! I think we can also keep the tag since not all repos use the version number in the name of the release (VS Code is one example). I think from a design perspective, this looks great and we should get this in. Design can always do a pass once they have cycles if they have further thoughts. :)

@davidegiacometti
Copy link
Contributor Author

@dkbennett and @cinnamon-msft thanks for the feedback!
I have updated the PR, added required tests and addressed most of the feedback.

@dkbennett dkbennett added the Needs-Second Pull request that needs another approval label Feb 21, 2024
<Icon Path="Widgets\Assets\GitHubLogo_Light.jpg" />
</Icons>
<Screenshots>
<Screenshot Path="Widgets\Assets\IssuesScreenshotLight.png" DisplayAltText="DevHomeGitHub icon" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to generate some first screenshots of this before we release it. Adding this comment as a reminder.

@davidegiacometti
Copy link
Contributor Author

davidegiacometti commented Feb 21, 2024

Tested/Reviewed this once again and rebased on main.
@guimafelipe I was about to ask who can help with those screenshots 😅

@davidegiacometti davidegiacometti marked this pull request as ready for review February 21, 2024 20:26
Copy link
Collaborator

@krschau krschau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking while we work on getting screenshots or getting instructions for them.

@krschau krschau self-assigned this Feb 23, 2024
Copy link
Collaborator

@krschau krschau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I DIY'ed some screenshots, I'll open a PR for them after checking this in

@krschau krschau merged commit 7eb898c into microsoft:main Mar 4, 2024
4 checks passed
@davidegiacometti davidegiacometti deleted the release-widget branch March 4, 2024 22:32
@krschau krschau removed the Needs-Second Pull request that needs another approval label Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub repo Releases widget
5 participants