-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Releases Widget #344
Add Releases Widget #344
Conversation
Need @cinnamon-msft to weigh in here for a new Widget. This is overall a good integration with the datastore that follows existing paradigms (except where otherwise noted), so apart from my changes above I have no objections to this widget, but design needs to weigh in on whether this fits into the extension. |
This looks awesome! I think we can also keep the tag since not all repos use the version number in the name of the release (VS Code is one example). I think from a design perspective, this looks great and we should get this in. Design can always do a pass once they have cycles if they have further thoughts. :) |
@dkbennett and @cinnamon-msft thanks for the feedback! |
<Icon Path="Widgets\Assets\GitHubLogo_Light.jpg" /> | ||
</Icons> | ||
<Screenshots> | ||
<Screenshot Path="Widgets\Assets\IssuesScreenshotLight.png" DisplayAltText="DevHomeGitHub icon" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will need to generate some first screenshots of this before we release it. Adding this comment as a reminder.
Tested/Reviewed this once again and rebased on main. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking while we work on getting screenshots or getting instructions for them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I DIY'ed some screenshots, I'll open a PR for them after checking this in
Summary of the pull request
Add a new widget that displays the releases of a repository.
References and relevant issues
#157
Detailed description of the pull request / Additional comments
Displayed info:
Available info:
Validation steps performed
PR checklist