Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue search sort order getting corrupted over time. #319

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

dkbennett
Copy link
Member

Summary of the pull request

This fixes an elusive search sort bug where over time the Issues widget when used with a Search query becomes corrupted and the search results go out of order.
 

References and relevant issues

Closes #278

Detailed description of the pull request / Additional comments

This bug originates in the parameter of the pruning method. The parameter for pruning the outdated search results was incorrectly specified (missing 1 character). This resulted in the actual query command once substituted to never match any records. Since nothing was ever removed when updating search results, the timestamp-based search result ordering was showing out of order.

Also fixed a horribly written comment.

Validation steps performed

  • I created the same search widget, then took a confirmed corrupted datastore that repro'd this issue and injected it into a built extension with the fix's datastore and restarted devhome to execute the updated code against the corrupted datastore. The result is that the issues search list was no longer corrupted and had only the current accurate results. This confirms that the fix heals an affected datastore without any action from the user other than taking an update with the fix.
  • Also confirmed search issue widgets work as expected with the change.

PR checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated

@dkbennett dkbennett merged commit 7d783a1 into main Jan 12, 2024
4 checks passed
EricJohnson327 pushed a commit that referenced this pull request Jan 18, 2024
* Fix incorrect parameter to search pruning command.

* Fix comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues widget shows issues in reverse order
4 participants