Add GitHub Enterprise Server support #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vineeththomasalex
requested review from
ssparach,
krschau,
guimafelipe,
dkbennett,
EricJohnson327,
AmelBawa-msft and
bbonaby
vineeththomasalex
added
the
Area-Account-Sign-In
AmelBawa-msft
approved these changes
Jan 10, 2024
dkbennett
approved these changes
Jan 11, 2024
vineeththomasalex
dismissed
jamespik’s stale review
Received permission to dismiss review from Jamespik
EricJohnson327
pushed a commit
that referenced
this pull request
Jan 18, 2024
* Explicitly disallow multiple accounts on GitHub extension * Fix constructor bug * Tested GHES * Stashing * Basic flow works * Validation added * Minor updates * Minor Widget update * SearchManager minor update * Fixed LoginUI * Created separate states for pages * Added CredentialVault Tests * Added LoginUI tests * Added some tests * Reverted Widget updates * Fixed tests * Revert changes to allow multi-user for tests * PR Comments 1 * PR comments 2 * Ignore some tests in pipeline * PR Comments 3 * PR Comments 4 * Minor update * PR comments 6 * PR Comments 7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
This PR contains the following changes:
Adds GitHub Enterprise Server (GHES) v3 Support (supported version determined by Octokit)
Adds LoginUI page for GHES flow to enter PAT
Refactors LoginUIController flow to be more encapsulated into Pages
Refactors CredentialVault to allow test configuration
Adds Unit Tests for DeveloperID components
Adds Functional tests for restoring and using saved credentials for repository query
Catches (and logs) a crash during Startup due to bad saved credentials
Also, enables multi-user support for widgets (requires Widget UI update in a follow-up PR)
References and relevant issues
microsoft/devhome#825
#235
LoginUI flow for GHES
Not uploading gif of 2nd page since it has personal info. Please try it out yourself.
Validation steps performed
Ran old and new tests, and manually ran through login flow, widget and setup flow.
PR checklist