Merge pull request #352 from microsoft/staging

Release - 2/20/24

.editorconfig

@@ -4,6 +4,8 @@
 
 [*.cs]
 
+file_header_template = Copyright (c) Microsoft Corporation.\r\nLicensed under the MIT License.
+
 #Core editorconfig formatting - indentation
 
 #use soft tabs (spaces) for indentation

.gitattributes

@@ -0,0 +1 @@
+* text=crlf

.github/policies/moderatorTriggers.yml

@@ -78,7 +78,7 @@ configuration:
       if:
       - payloadType: Issue_Comment
       - commentContains:
-          pattern: '\/logs)'
+          pattern: '\/logs'
           isRegex: True
       - or:
         - activitySenderHasAssociation:
@@ -98,9 +98,6 @@ configuration:
               repo names). Alternatively, you can open a Feedback Hub issue and attach them there. 
               If you use Feedback Hub, please paste the URL at the bottom of the report here so we 
               can easily find it. 
-      - closeIssue
-      - removeLabel:
-          label: Needs-Triage
       - removeLabel:
           label: Needs-Team-Response
     #
@@ -119,8 +116,6 @@ configuration:
         - activitySenderHasAssociation:
             association: Member
       then:
-      - removeLabel:
-          label: Needs-Triage
       - removeLabel:
           label: Needs-Team-Response
       - addLabel:

Directory.Build.props

@@ -39,7 +39,7 @@
     <Compile Include="$(MSBuildThisFileDirectory)\codeAnalysis\GlobalSuppressions.cs" Link="GlobalSuppressions.cs" />
     <AdditionalFiles Include="$(MSBuildThisFileDirectory)\codeAnalysis\StyleCop.json" Link="StyleCop.json" />
 
-    <PackageReference Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="6.0.0">
+    <PackageReference Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="8.0.0">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>

GitHubExtension.sln

@@ -48,6 +48,12 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "scripts", "scripts", "{E4D6
 		test\scripts\CleanWidgets.ps1 = test\scripts\CleanWidgets.ps1
 	EndProjectSection
 EndProject
+Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{864DD9CD-9F45-47E8-847F-B72ED182626B}"
+	ProjectSection(SolutionItems) = preProject
+		.editorconfig = .editorconfig
+		exclusion.dic = exclusion.dic
+	EndProjectSection
+EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
 		Debug|Any CPU = Debug|Any CPU

TestingScenarios.md

@@ -1,15 +1,17 @@
 ## Testing Scenarios
-These are the testing scenarios that need to be validated before shipping a new release.  When an automated test is added, please remove it from the below lists.
 
+These are the testing scenarios that need to be validated before shipping a new release.  When an automated test is added, please remove it from the below lists.
 
 ### Widgets
-1. For each widget: user can configure the widget before pinning
-1. For each widget: user can see widget in dashboard after pinning
+
+1. For each widget: user can configure the widget immediately after first pin
+1. For each widget: user can customize (reconfigure) the widget after it was initially configured
 1. For each widget that supports customization: can be customized and persist after restart
 1. Widgets have correct data
 1. Widgets are adequately performant
 1. Notifications can be enabled/disabled in Dev Home settings
 1. Notifications are displayed
 
 ### Clone repositories
-1. User can log in and get the list of repositories
+
+1. User can log in and get the list of repositories

build/azure-pipelines.yml

@@ -20,7 +20,7 @@ parameters:
     - release
 
 variables:
-  MSIXVersion: '0.1000'
+  MSIXVersion: '0.1100'
   solution: '**/GitHubExtension.sln'
   appxPackageDir: 'AppxPackages'
   testOutputArtifactDir: 'TestResults'

build/scripts/Build.ps1

@@ -14,7 +14,7 @@ $StartTime = Get-Date
 
 if ($Help) {
     Write-Host @"
-Copyright (c) Microsoft Corporation and Contributors.
+Copyright (c) Microsoft Corporation.
 Licensed under the MIT License.
 
 Syntax:

build/scripts/CreateBuildInfo.ps1

@@ -5,7 +5,7 @@ Param(
 )
 
 $Major = "0"
-$Minor = "10"
+$Minor = "11"
 $Patch = "99" # default to 99 for local builds
 
 $versionSplit = $Version.Split(".");

build/scripts/Test.ps1

@@ -9,7 +9,7 @@ $StartTime = Get-Date
 
 if ($Help) {
     Write-Host @"
-Copyright (c) Microsoft Corporation and Contributors.
+Copyright (c) Microsoft Corporation.
 Licensed under the MIT License.
 
 Syntax:

build/scripts/Unstub.ps1

@@ -10,12 +10,12 @@ if ($projFileContent.Contains('Microsoft.Telemetry.Inbox.Managed')) {
     return;
 }
 
-$xml = [xml]$projFileContent
+$xml = [System.Xml.XmlDocument]$projFileContent
 $xml.PreserveWhitespace = $true
-$packageRef = $xml.SelectSingleNode("//ItemGroup/PackageReference")
-$newNode = $packageRef.Clone()
-$newNode.Include="Microsoft.Telemetry.Inbox.Managed"
-$newNode.Version="10.0.25148.1001-220626-1600.rs-fun-deploy-dev5"
-$parentNode = $packageRef.ParentNode
-$parentNode.AppendChild($newNode)
+$itemGroup = $xml.CreateElement("ItemGroup")
+$packageRef = $xml.CreateElement("PackageReference")
+$packageRef.SetAttribute("Include", "Microsoft.Telemetry.Inbox.Managed")
+$packageRef.SetAttribute("Version", "10.0.25148.1001-220626-1600.rs-fun-deploy-dev5")
+$itemGroup.AppendChild($packageRef)
+$xml.Project.AppendChild($itemGroup)
 $xml.Save($projFile)

codeAnalysis/GlobalSuppressions.cs

@@ -1,5 +1,5 @@
-// Copyright (c) Microsoft Corporation and Contributors
-// Licensed under the MIT license.
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT License.
 
 // This file is used by Code Analysis to maintain SuppressMessage
 // attributes that are applied to this project.
@@ -13,10 +13,10 @@
 [assembly: SuppressMessage("StyleCop.CSharp.ReadabilityRules", "SA1101:PrefixLocalCallsWithThis", Justification = "We follow the C# Core Coding Style which avoids using `this` unless absolutely necessary.")]
 
 [assembly: SuppressMessage("StyleCop.CSharp.OrderingRules", "SA1200:UsingDirectivesMustBePlacedWithinNamespace", Justification = "We follow the C# Core Coding Style which puts using statements outside the namespace.")]
-[assembly: SuppressMessage("StyleCop.CSharp.OrderingRules", "SA1201:ElementsMustAppearInTheCorrectOrder", Justification = "It is not a priority and have hight impact in code changes.")]
-[assembly: SuppressMessage("StyleCop.CSharp.OrderingRules", "SA1202:ElementsMustBeOrderedByAccess", Justification = "It is not a priority and have hight impact in code changes.")]
-[assembly: SuppressMessage("StyleCop.CSharp.OrderingRules", "SA1203:ConstantsMustAppearBeforeFields", Justification = "It is not a priority and have hight impact in code changes.")]
-[assembly: SuppressMessage("StyleCop.CSharp.OrderingRules", "SA1204:StaticElementsMustAppearBeforeInstanceElements", Justification = "It is not a priority and have hight impact in code changes.")]
+[assembly: SuppressMessage("StyleCop.CSharp.OrderingRules", "SA1201:ElementsMustAppearInTheCorrectOrder", Justification = "It is not a priority and has high impact in code changes.")]
+[assembly: SuppressMessage("StyleCop.CSharp.OrderingRules", "SA1202:ElementsMustBeOrderedByAccess", Justification = "It is not a priority and has high impact in code changes.")]
+[assembly: SuppressMessage("StyleCop.CSharp.OrderingRules", "SA1203:ConstantsMustAppearBeforeFields", Justification = "It is not a priority and has high impact in code changes.")]
+[assembly: SuppressMessage("StyleCop.CSharp.OrderingRules", "SA1204:StaticElementsMustAppearBeforeInstanceElements", Justification = "It is not a priority and has high impact in code changes.")]
 
 [assembly: SuppressMessage("StyleCop.CSharp.NamingRules", "SA1309:FieldNamesMustNotBeginWithUnderscore", Justification = "We follow the C# Core Coding Style which uses underscores as prefixes rather than using `this.`.")]
 

codeAnalysis/StyleCop.json

@@ -3,7 +3,7 @@
   "settings": {
     "documentationRules": {
       "companyName": "Microsoft Corporation",
-      "copyrightText": "Copyright (c) Microsoft Corporation and Contributors\r\nLicensed under the MIT license.",
+      "copyrightText": "Copyright (c) Microsoft Corporation.\r\nLicensed under the MIT License.",
       "xmlHeader": false,
       "headerDecoration": "",
       "fileNamingConvention": "metadata",

docs/specs/spec-template.md

@@ -1,58 +1,58 @@
----
-author: <first-name> <last-name> <github-id>/<email>
-created on: <yyyy-mm-dd>
-last updated: <yyyy-mm-dd>
-issue id: <github issue id>
----
-
-# Spec Title
-
-## Abstract
-
-[comment]: # Outline what this spec describes
-
-## Inspiration
-
-[comment]: # What were the drivers/inspiration behind the creation of this spec.
-
-## Solution Design
-
-[comment]: # Outline the design of the solution. Feel free to include ASCII-art diagrams, etc.
-
-## UI/UX Design
-
-[comment]: # What will this fix/feature look like? How will it affect the end user?
-
-## Capabilities
-
-[comment]: # Discuss how the proposed fixes/features impact the following key considerations:
-
-### Accessibility
-
-[comment]: # How will the proposed change impact accessibility for users of screen readers, assistive input devices, etc.
-
-### Security
-
-[comment]: # How will the proposed change impact security?
-
-### Reliability
-
-[comment]: # Will the proposed change improve reliability? If not, why make the change?
-
-### Compatibility
-
-[comment]: # Will the proposed change break existing code/behaviors? If so, how, and is the breaking change "worth it"?
-
-### Performance, Power, and Efficiency
-
-## Potential Issues
-
-[comment]: # What are some of the things that might cause problems with the fixes/features proposed? Consider how the user might be negatively impacted.
-
-## Future considerations
-
-[comment]: # What are some of the things that the fixes/features might unlock in the future? Does the implementation of this spec enable scenarios?
-
-## Resources
-
+---
+author: <first-name> <last-name> <github-id>/<email>
+created on: <yyyy-mm-dd>
+last updated: <yyyy-mm-dd>
+issue id: <github issue id>
+---
+
+# Spec Title
+
+## Abstract
+
+[comment]: # Outline what this spec describes
+
+## Inspiration
+
+[comment]: # What were the drivers/inspiration behind the creation of this spec.
+
+## Solution Design
+
+[comment]: # Outline the design of the solution. Feel free to include ASCII-art diagrams, etc.
+
+## UI/UX Design
+
+[comment]: # What will this fix/feature look like? How will it affect the end user?
+
+## Capabilities
+
+[comment]: # Discuss how the proposed fixes/features impact the following key considerations:
+
+### Accessibility
+
+[comment]: # How will the proposed change impact accessibility for users of screen readers, assistive input devices, etc.
+
+### Security
+
+[comment]: # How will the proposed change impact security?
+
+### Reliability
+
+[comment]: # Will the proposed change improve reliability? If not, why make the change?
+
+### Compatibility
+
+[comment]: # Will the proposed change break existing code/behaviors? If so, how, and is the breaking change "worth it"?
+
+### Performance, Power, and Efficiency
+
+## Potential Issues
+
+[comment]: # What are some of the things that might cause problems with the fixes/features proposed? Consider how the user might be negatively impacted.
+
+## Future considerations
+
+[comment]: # What are some of the things that the fixes/features might unlock in the future? Does the implementation of this spec enable scenarios?
+
+## Resources
+
 [comment]: # Be sure to add links to references, resources, footnotes, etc.

exclusion.dic

@@ -1 +1,14 @@
 devhome
+enums
+Octokit
+advapi
+Urls
+Dependabot
+github.com
+inlines
+abcd
+Doggos
+Stringify
+riid
+Impl
+microsoft

src/GitHubExtension/Client/Exceptions.cs

@@ -1,39 +1,40 @@
-// Copyright (c) Microsoft Corporation and Contributors
-// Licensed under the MIT license.
-
-namespace GitHubExtension.Client;
-public class InvalidUrlException : Exception
-{
-    public InvalidUrlException()
-    {
-    }
-
-    public InvalidUrlException(string message)
-        : base(message)
-    {
-    }
-}
-
-public class InvalidGitHubUrlException : Exception
-{
-    public InvalidGitHubUrlException()
-    {
-    }
-
-    public InvalidGitHubUrlException(string message)
-        : base(message)
-    {
-    }
-}
-
-public class InvalidApiException : Exception
-{
-    public InvalidApiException()
-    {
-    }
-
-    public InvalidApiException(string message)
-        : base(message)
-    {
-    }
-}
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT License.
+
+namespace GitHubExtension.Client;
+
+public class InvalidUrlException : Exception
+{
+    public InvalidUrlException()
+    {
+    }
+
+    public InvalidUrlException(string message)
+        : base(message)
+    {
+    }
+}
+
+public class InvalidGitHubUrlException : Exception
+{
+    public InvalidGitHubUrlException()
+    {
+    }
+
+    public InvalidGitHubUrlException(string message)
+        : base(message)
+    {
+    }
+}
+
+public class InvalidApiException : Exception
+{
+    public InvalidApiException()
+    {
+    }
+
+    public InvalidApiException(string message)
+        : base(message)
+    {
+    }
+}