Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include WidgetService #417

Closed
wants to merge 4 commits into from
Closed

Include WidgetService #417

wants to merge 4 commits into from

Conversation

krschau
Copy link
Collaborator

@krschau krschau commented May 12, 2023

Summary of the pull request

Includes a Dev Home-specific copy of the WidgetService that will be used on Windows 10, or machines where the Win11 WidgetService has been uninstalled. Needs WindowsAppSDK version 1.3.1 (1.3 servicing 1) to correctly select which version to use.

DevHomeGitHubExtension change: microsoft/devhomegithubextension#75

References and relevant issues

Detailed description of the pull request / Additional comments

Validation steps performed

PR checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated

@krschau
Copy link
Collaborator Author

krschau commented May 12, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@chendrixson chendrixson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not supporting win10 for the initial //BUILD release and I don't want to bring in things to try and support it without having a fully baked test plan etc/ around it. SO maybe we need part of this to just grab the new APIs, but we don't need the service/etc.

@krschau krschau marked this pull request as draft May 12, 2023 18:43
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kristen you can take off the support for Win 10 from build. We already started announcing Coming soon support for win 10. Save it for post build.

Copy link
Contributor

@mathewleeza mathewleeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned below please remove any chnage that give Win 10 Support

@krschau krschau mentioned this pull request May 12, 2023
3 tasks
@crutkas
Copy link
Member

crutkas commented May 13, 2023

how do we get off internal nuget feeds then

@krschau krschau force-pushed the user/krschau/win10 branch 2 times, most recently from 68ebff8 to b510597 Compare May 22, 2023 16:07
@krschau krschau linked an issue May 23, 2023 that may be closed by this pull request
@krschau krschau force-pushed the user/krschau/win10 branch from b510597 to ad6d752 Compare August 14, 2023 16:42
@krschau
Copy link
Collaborator Author

krschau commented Aug 14, 2023

Closing, until and if Dev Home supports Windows 10.

@krschau krschau closed this Aug 14, 2023
@nicoabie
Copy link

We're not supporting win10 for the initial //BUILD release and I don't want to bring in things to try and support it without having a fully baked test plan etc/ around it. SO maybe we need part of this to just grab the new APIs, but we don't need the service/etc.

I just want to note that a lot of feedback can be provided by win10 users that are not able to update to win11 because of hardware requirements. Win11 relies on tpm and there is a ton of great computers with a lot of resources and capabilities that don't meet that requirement.

Thanks for the great work and keep it up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows 10 support
5 participants