-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include WidgetService #417
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're not supporting win10 for the initial //BUILD release and I don't want to bring in things to try and support it without having a fully baked test plan etc/ around it. SO maybe we need part of this to just grab the new APIs, but we don't need the service/etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kristen you can take off the support for Win 10 from build. We already started announcing Coming soon support for win 10. Save it for post build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned below please remove any chnage that give Win 10 Support
how do we get off internal nuget feeds then |
68ebff8
to
b510597
Compare
b510597
to
ad6d752
Compare
Closing, until and if Dev Home supports Windows 10. |
I just want to note that a lot of feedback can be provided by win10 users that are not able to update to win11 because of hardware requirements. Win11 relies on tpm and there is a ton of great computers with a lot of resources and capabilities that don't meet that requirement. Thanks for the great work and keep it up! |
Summary of the pull request
Includes a Dev Home-specific copy of the WidgetService that will be used on Windows 10, or machines where the Win11 WidgetService has been uninstalled. Needs WindowsAppSDK version 1.3.1 (1.3 servicing 1) to correctly select which version to use.
DevHomeGitHubExtension change: microsoft/devhomegithubextension#75
References and relevant issues
Detailed description of the pull request / Additional comments
Validation steps performed
PR checklist